-
Notifications
You must be signed in to change notification settings - Fork 518
Logs extend invalid schedule delay tests #3812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Logs extend invalid schedule delay tests #3812
Conversation
|
Seem we have caught a bug in the code here as CI is failing. Either ignore/comment the failing test adding a TODO, or fix the code (should be easy fix I guess). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3812 +/- ##
==========================================
+ Coverage 89.96% 89.96% +0.01%
==========================================
Files 225 225
Lines 7167 7170 +3
==========================================
+ Hits 6447 6450 +3
Misses 720 720
🚀 New features to boost your workflow:
|
|
The test failure exposed a missing overflow check in One clarification question: is a duration value of 0 intended to be valid? |
owent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the format issued is fixed.
db24eb6 to
9c9e9c5
Compare
This PR extends test coverage for OTEL_BLRP_SCHEDULE_DELAY to include
additional invalid inputs such as negatives, zero, overflow,
and empty strings.
Follow-up to #3811.