Resolve warnings

rmf_visualization_rviz2_plugins/src/LiftPanel.cpp

@@ -377,7 +377,7 @@ void LiftPanel::lift_state_callback(LiftState::UniquePtr msg)
 void LiftPanel::display_state(const LiftState& msg)
 {
   std::string floors_str = "";
-  for (const auto f : msg.available_floors)
+  for (const auto& f : msg.available_floors)
     floors_str += f + ", ";
 
   std::string available_modes_str = "";

rmf_visualization_rviz2_plugins/src/NegotiationModel.cpp

@@ -63,6 +63,7 @@ uint64_t NegotiationModel::get_negotiation_id(std::size_t n)
     }
     _current_row++;
   }
+  return 0;
 }
 
 QString NegotiationModel::render_participants(uint64_t conflict_version)

rmf_visualization_schedule/src/rmf_visualization_schedule/ScheduleDataNode.cpp

@@ -74,7 +74,7 @@ std::shared_ptr<ScheduleDataNode> ScheduleDataNode::make(
 {
   const auto start_time = std::chrono::steady_clock::now();
   std::shared_ptr<ScheduleDataNode> schedule_data(
-    new ScheduleDataNode(std::move(node_name), options));
+    new ScheduleDataNode(node_name, options));
 
   // Creating a mirror manager that queries over all
   // Spacetime in the database schedule

rmf_visualization_schedule/src/rmf_visualization_schedule/TrajectoryServer.cpp

@@ -121,7 +121,6 @@ auto TrajectoryServer::Implementation::on_message(
   // validate jwt only if public key is given (when running with dashboard)
   std::string public_key;
   std::string token;
-  bool is_verified = true;
   if (std::getenv("JWT_PUBLIC_KEY"))
   {
     public_key = std::getenv("JWT_PUBLIC_KEY");