Skip to content

Resolve warnings#90

Merged
aaronchongth merged 2 commits intomainfrom
resolve-warnings
Apr 8, 2026
Merged

Resolve warnings#90
aaronchongth merged 2 commits intomainfrom
resolve-warnings

Conversation

@aaronchongth
Copy link
Copy Markdown
Member

Bug fix

Fixed bug

Taking inspiration from open-rmf/rmf_traffic#132, I performed source builds of Open-RMF and asked the agent to list out compilation warnings with easy and non-intrusive fixes throughout the code base.

More PRs will be opened in other repositories.

Fix applied

  • missing references
  • missing return
  • unnecessary std::move calls
  • unused parameters or variables

I've skipped any of the required changes that were too intrusive to reduce the compiler warnings.

Overall stats regarding compilation warnings that were not related to thirdparty libraries or vendored libraries,

  • compilation warnings on main: ~187
  • after fixes throughout codebase: ~86
  • reduced 101 warnings (-54%)

GenAI Use

We follow OSRA's policy on GenAI tools

  • I used a GenAI tool in this PR.
  • I did not use GenAI

Generated-by: Claude Sonnet 4.6

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@mxgrey mxgrey added this to PMC Board Apr 7, 2026
@github-project-automation github-project-automation bot moved this to Inbox in PMC Board Apr 7, 2026
@aaronchongth aaronchongth requested a review from xiyuoh April 8, 2026 02:15
@aaronchongth aaronchongth merged commit 590cf6d into main Apr 8, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in PMC Board Apr 8, 2026
@aaronchongth aaronchongth deleted the resolve-warnings branch April 8, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants