Skip to content

skip NotificationAlerts.spec.ts #26719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShaileshParmar11 merged 2 commits into from
Mar 24, 2026
Merged

skip NotificationAlerts.spec.ts #26719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd56424
skip NotificationAlerts.spec.ts
ShaileshParmar11 Mar 24, 2026
fa6fc52
Merge branch 'main' into skip-notification-test
ShaileshParmar11 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/NotificationAlerts.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
visitEditAlertPage,
} from '../../utils/alert';
import { descriptionBox, getApiContext } from '../../utils/common';
import { waitForAllLoadersToDisappear } from '../../utils/entity';
import {
addFilterWithUsersListInput,
addInternalDestination,
Expand All @@ -43,7 +44,6 @@ import {
visitNotificationAlertPage,
} from '../../utils/notificationAlert';
import { addExternalDestination } from '../../utils/observabilityAlert';
import { waitForAllLoadersToDisappear } from '../../utils/entity';

const dashboard = new DashboardClass();
const table = new TableClass();
Expand Down Expand Up @@ -423,12 +423,13 @@ test('Conversation source alert', async ({ page }) => {
});
});

// Todo: Re-enable after fixing the https://github.com/open-metadata/openmetadata-collate/issues/3280 @sonika-shah
/**
* Alert operations with permissions
* @description Creates and triggers a Table source alert; verifies alert details for permissive user and limited behavior
* for a non-permissive user; deletes the alert.
*/
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test.skip(...) is being introduced without disabling the playwright/no-skipped-test ESLint rule. Other skipped Playwright tests in this repo add an // eslint-disable-next-line playwright/no-skipped-test -- <reason> immediately above the skip, so this change is likely to fail yarn lint in CI unless the disable (with a reason/link) is added (or the test is converted to test.fixme(...) if that’s the intended pattern).

Suggested change
*/
*/
// eslint-disable-next-line playwright/no-skipped-test -- Temporarily disabled; see https://github.com/open-metadata/openmetadata-collate/issues/3280

Copilot uses AI. Check for mistakes.
test('Alert operations for a user with and without permissions', async ({
test.skip('Alert operations for a user with and without permissions', async ({
Comment on lines +426 to +432
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description still contains template placeholders (e.g., Fixes <issue-number> / I worked on ... because ...) while the code change is explicitly tied to open-metadata/openmetadata-collate#3280. Please update the PR title/description to reference the real issue and clarify why this test is being skipped and when it should be re-enabled.

Copilot uses AI. Check for mistakes.
page,
userWithPermissionsPage,
userWithoutPermissionsPage,
Expand Down
Loading