Skip to content

skip NotificationAlerts.spec.ts#26719

Merged
ShaileshParmar11 merged 2 commits intomainfrom
skip-notification-test
Mar 24, 2026
Merged

skip NotificationAlerts.spec.ts#26719
ShaileshParmar11 merged 2 commits intomainfrom
skip-notification-test

Conversation

@ShaileshParmar11
Copy link
Contributor

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ShaileshParmar11 ShaileshParmar11 self-assigned this Mar 24, 2026
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Mar 24, 2026
@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review March 24, 2026 09:53
@ShaileshParmar11 ShaileshParmar11 requested a review from a team as a code owner March 24, 2026 09:53
Copilot AI review requested due to automatic review settings March 24, 2026 09:53
@gitar-bot
Copy link

gitar-bot bot commented Mar 24, 2026

Code Review ✅ Approved

Skips the NotificationAlerts.spec.ts test to address a known issue. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily disables a flaky/blocked Playwright E2E scenario in the notification alerts flow, and tidies an import placement in the same spec file.

Changes:

  • Marked “Alert operations for a user with and without permissions” as skipped in NotificationAlerts.spec.ts (referencing openmetadata-collate#3280).
  • Moved waitForAllLoadersToDisappear import to align with nearby imports.

* Alert operations with permissions
* @description Creates and triggers a Table source alert; verifies alert details for permissive user and limited behavior
* for a non-permissive user; deletes the alert.
*/
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test.skip(...) is being introduced without disabling the playwright/no-skipped-test ESLint rule. Other skipped Playwright tests in this repo add an // eslint-disable-next-line playwright/no-skipped-test -- <reason> immediately above the skip, so this change is likely to fail yarn lint in CI unless the disable (with a reason/link) is added (or the test is converted to test.fixme(...) if that’s the intended pattern).

Suggested change
*/
*/
// eslint-disable-next-line playwright/no-skipped-test -- Temporarily disabled; see https://github.com/open-metadata/openmetadata-collate/issues/3280

Copilot uses AI. Check for mistakes.
Comment on lines +426 to +432
// Todo: Re-enable after fixing the https://github.com/open-metadata/openmetadata-collate/issues/3280 @sonika-shah
/**
* Alert operations with permissions
* @description Creates and triggers a Table source alert; verifies alert details for permissive user and limited behavior
* for a non-permissive user; deletes the alert.
*/
test('Alert operations for a user with and without permissions', async ({
test.skip('Alert operations for a user with and without permissions', async ({
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description still contains template placeholders (e.g., Fixes <issue-number> / I worked on ... because ...) while the code change is explicitly tied to open-metadata/openmetadata-collate#3280. Please update the PR title/description to reference the real issue and clarify why this test is being skipped and when it should be re-enabled.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
65.01% (58080/89328) 44.8% (30712/68547) 47.8% (9196/19235)

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

🟡 Playwright Results — all passed (19 flaky)

✅ 3110 passed · ❌ 0 failed · 🟡 19 flaky · ⏭️ 208 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 453 0 2 2
🟡 Shard 2 541 0 5 33
🟡 Shard 3 542 0 3 28
🟡 Shard 4 533 0 5 45
✅ Shard 5 511 0 0 67
🟡 Shard 6 530 0 4 33
🟡 19 flaky test(s) (passed on retry)
  • Features/CustomizeDetailPage.spec.ts › Data Product - customization should work (shard 1, 1 retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/BulkImport.spec.ts › Keyboard Delete selection (shard 2, 1 retry)
  • Features/DataQuality/TestCaseIncidentPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit icon on incidents (shard 2, 1 retry)
  • Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 2, 1 retry)
  • Features/ImpactAnalysis.spec.ts › Verify Upstream connections (shard 2, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Flow/LineageSettings.spec.ts › Verify global lineage config (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 3, 1 retry)
  • Pages/DataProductAndSubdomains.spec.ts › Add expert to data product via UI (shard 4, 1 retry)
  • Pages/DomainAdvanced.spec.ts › Add multiple assets to domain at once (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Set & update column-level custom property (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Announcement create, edit & delete (shard 4, 1 retry)
  • Pages/Entity.spec.ts › User as Owner with unsorted list (shard 4, 1 retry)
  • Pages/Lineage.spec.ts › Lineage creation from Table entity (shard 6, 1 retry)
  • Pages/Teams.spec.ts › Add and Remove User for Team (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@ShaileshParmar11 ShaileshParmar11 merged commit 6b6f528 into main Mar 24, 2026
72 of 81 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the skip-notification-test branch March 24, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants