skip NotificationAlerts.spec.ts#26719
Conversation
Code Review ✅ ApprovedSkips the NotificationAlerts.spec.ts test to address a known issue. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
There was a problem hiding this comment.
Pull request overview
This PR temporarily disables a flaky/blocked Playwright E2E scenario in the notification alerts flow, and tidies an import placement in the same spec file.
Changes:
- Marked “Alert operations for a user with and without permissions” as skipped in
NotificationAlerts.spec.ts(referencing openmetadata-collate#3280). - Moved
waitForAllLoadersToDisappearimport to align with nearby imports.
| * Alert operations with permissions | ||
| * @description Creates and triggers a Table source alert; verifies alert details for permissive user and limited behavior | ||
| * for a non-permissive user; deletes the alert. | ||
| */ |
There was a problem hiding this comment.
test.skip(...) is being introduced without disabling the playwright/no-skipped-test ESLint rule. Other skipped Playwright tests in this repo add an // eslint-disable-next-line playwright/no-skipped-test -- <reason> immediately above the skip, so this change is likely to fail yarn lint in CI unless the disable (with a reason/link) is added (or the test is converted to test.fixme(...) if that’s the intended pattern).
| */ | |
| */ | |
| // eslint-disable-next-line playwright/no-skipped-test -- Temporarily disabled; see https://github.com/open-metadata/openmetadata-collate/issues/3280 |
| // Todo: Re-enable after fixing the https://github.com/open-metadata/openmetadata-collate/issues/3280 @sonika-shah | ||
| /** | ||
| * Alert operations with permissions | ||
| * @description Creates and triggers a Table source alert; verifies alert details for permissive user and limited behavior | ||
| * for a non-permissive user; deletes the alert. | ||
| */ | ||
| test('Alert operations for a user with and without permissions', async ({ | ||
| test.skip('Alert operations for a user with and without permissions', async ({ |
There was a problem hiding this comment.
PR description still contains template placeholders (e.g., Fixes <issue-number> / I worked on ... because ...) while the code change is explicitly tied to open-metadata/openmetadata-collate#3280. Please update the PR title/description to reference the real issue and clarify why this test is being skipped and when it should be re-enabled.
|
🟡 Playwright Results — all passed (19 flaky)✅ 3110 passed · ❌ 0 failed · 🟡 19 flaky · ⏭️ 208 skipped
🟡 19 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |



Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>