Skip to content

fix: Correct logic for evaluation blocked for ERROR and STALE providers #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NeaguGeorgiana23 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Correct logic for evaluation blocked for ERROR and STALE providers #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a47e6f4
Correct logic for evaluation blocked for ERROR and STALE providers
NeaguGeorgiana23 May 11, 2026
06c2c12
Fix linter
NeaguGeorgiana23 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion openfeature/client_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,17 @@ template <typename ResolutionDetailsType, typename ValueType,
std::unique_ptr<ResolutionDetailsType> ClientAPI::EvaluateFlag(
ValueType default_value, const std::optional<EvaluationContext>& ctx,
ProviderCallable provider_call) {
if (GetProviderStatus() != ProviderStatus::kReady) {
ProviderStatus status = GetProviderStatus();
if (status == ProviderStatus::kNotReady) {
return std::make_unique<ResolutionDetailsType>(
default_value, Reason::kError, std::nullopt, FlagMetadata(),
ErrorCode::kProviderNotReady, "Provider is not ready");
}
if (status == ProviderStatus::kFatal) {
return std::make_unique<ResolutionDetailsType>(
default_value, Reason::kError, std::nullopt, FlagMetadata(),
ErrorCode::kProviderFatal, "Provider is in fatal error state");
}

std::shared_ptr<FeatureProvider> provider =
provider_repository_.GetProvider(domain_);
Expand Down
Loading