fix: Correct logic for evaluation blocked for ERROR and STALE providers#96
Open
NeaguGeorgiana23 wants to merge 2 commits into
Open
fix: Correct logic for evaluation blocked for ERROR and STALE providers#96NeaguGeorgiana23 wants to merge 2 commits into
NeaguGeorgiana23 wants to merge 2 commits into
Conversation
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
There was a problem hiding this comment.
Code Review
This pull request updates the EvaluateFlag method in ClientAPI to explicitly handle different provider statuses. It replaces the generic non-ready check with specific logic for ProviderStatus::kNotReady and ProviderStatus::kFatal, ensuring that a fatal provider state returns the appropriate ErrorCode::kProviderFatal. I have no feedback to provide as there were no review comments to evaluate.
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
oxddr
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Fixes the flag evaluation which was incorrectly blocked when the feature provider was in
ERRORorSTALEstates.Previously, the SDK short-circuited evaluation for any provider status other than
READY. This PR updates theEvaluateFlaglogic to strictly follow the OpenFeature specification by:PROVIDER_NOT_READYerror code only when the provider isNOT_READY(Requirement 1.7.6).PROVIDER_FATALerror code only when the provider is in aFATALerror state (Requirement 1.7.7).READY,ERROR, andSTALEstates, ensuring cached values can still be returned when appropriate.Related Issues
Fixes #69
Notes
Follow-up Tasks