Skip to content

obvious fix: include _embedded field in device model #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rotarydrone wants to merge 2 commits into
base: master
Choose a base branch
from
Open

obvious fix: include _embedded field in device model #488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3708409
include _embedded field in device model
rotarydrone Jan 22, 2026
7b3699a
actually include _embedded in model
rotarydrone Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions okta/models/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ class Device(BaseModel):
)
resource_type: Optional[StrictStr] = Field(default="UDDevice", alias="resourceType")
status: Optional[DeviceStatus] = None
embedded: Optional[Dict[str, Any]] = Field(
default=None, alias="_embedded", description="Embedded resources like users when expand parameter is used"
)
links: Optional[LinksSelfAndFullUsersLifecycle] = Field(
default=None, alias="_links"
)
Expand All @@ -83,6 +86,7 @@ class Device(BaseModel):
"resourceId",
"resourceType",
"status",
"_embedded",
"_links",
]

Expand Down Expand Up @@ -193,6 +197,7 @@ def from_dict(cls, obj: Optional[Dict[str, Any]]) -> Optional[Self]:
else "UDDevice"
),
"status": obj.get("status"),
"_embedded": obj.get("_embedded"),
"_links": (
LinksSelfAndFullUsersLifecycle.from_dict(obj["_links"])
if obj.get("_links") is not None
Expand Down