obvious fix: include _embedded field in device model#488
Closed
rotarydrone wants to merge 2 commits intookta:masterfrom
Closed
obvious fix: include _embedded field in device model#488rotarydrone wants to merge 2 commits intookta:masterfrom
rotarydrone wants to merge 2 commits intookta:masterfrom
Conversation
Contributor
|
Hi @rotarydrone, I have reviewed the changes implemented over this PR. Thank you for your contribution to the SDK. Here is the update on the same.
Hence, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_embeddedis not actually included in the device model even though the documentation says so. This renders theexpandparameter useless for the device api client.