Skip to content

Fix Storybook build by ensuring workspace dependencies are built first #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 4 commits into from
Jan 28, 2026
Merged

Fix Storybook build by ensuring workspace dependencies are built first #251

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e990ec4
Initial plan
Copilot Jan 28, 2026
035bd17
Add prebuild-storybook script to build dependencies before Storybook
Copilot Jan 28, 2026
1444c96
Update pretest script to also build @object-ui/types for consistency
Copilot Jan 28, 2026
72587a5
Refactor to use shared prebuild script to reduce duplication
Copilot Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,13 @@
},
"scripts": {
"build": "vite build",
"pretest": "pnpm --filter @object-ui/core build && pnpm --filter @object-ui/react build",
"prebuild": "pnpm --filter @object-ui/types build && pnpm --filter @object-ui/core build && pnpm --filter @object-ui/react build",
"pretest": "pnpm run prebuild",
"test": "vitest run",
"type-check": "tsc --noEmit",
"lint": "eslint .",
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Storybook dev script (storybook) likely has the same workspace-resolution problem as build-storybook: stories import local renderers that import @object-ui/core at runtime, and @object-ui/core resolves to ./dist/index.js. In a clean checkout (no prior tsc), pnpm run storybook will still fail because there is no prestorybook hook to build the workspace deps first. Consider adding a prestorybook script that runs pnpm run prebuild (or otherwise ensuring deps are built before storybook dev).

Suggested change
"lint": "eslint .",
"lint": "eslint .",
"prestorybook": "pnpm run prebuild",

Copilot uses AI. Check for mistakes.
"storybook": "storybook dev -p 6006",
"prebuild-storybook": "pnpm run prebuild",
"build-storybook": "storybook build"
},
"dependencies": {
Expand Down
Loading