Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Vercel's Storybook build for @object-ui/components fails because it attempts to resolve @object-ui/core before its TypeScript compilation has run. The package.json points to ./dist/index.js, but dist/ doesn't exist until tsc runs.

Changes

  • Added prebuild-storybook hook to build workspace dependencies (@object-ui/types, @object-ui/core, @object-ui/react) before Storybook builds
  • Extracted shared prebuild script to eliminate duplication between pretest and prebuild-storybook
  • Updated pretest to include @object-ui/types for consistency

packages/components/package.json:

"scripts": {
  "prebuild": "pnpm --filter @object-ui/types build && pnpm --filter @object-ui/core build && pnpm --filter @object-ui/react build",
  "pretest": "pnpm run prebuild",
  "prebuild-storybook": "pnpm run prebuild",
  "build-storybook": "storybook build"
}

The prebuild-storybook hook executes automatically when pnpm run build-storybook is called, ensuring dependencies are compiled in dependency order before Storybook attempts to bundle them.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • storybook.js.org
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/objectui/objectui/packages/components/node_modules/.bin/../storybook/bin/index.cjs build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

18:34:42.868 Running build in Washington, D.C., USA (East) – iad1
18:34:42.869 Build machine configuration: 4 cores, 8 GB
18:34:42.979 Cloning github.com/objectstack-ai/objectui (Branch: main, Commit: 8ce9942)
18:34:42.980 Previous build caches not available.
18:34:43.362 Cloning completed: 382.000ms
18:34:43.915 Running "vercel build"
18:34:44.883 Vercel CLI 50.5.2
18:34:45.490 Detected pnpm-lock.yaml 9 which may be generated by pnpm@9.x or pnpm@10.x
18:34:45.490 Using pnpm@10.x based on project creation date
18:34:45.490 To use pnpm@9.x, manually opt in using corepack (https://vercel.com/docs/deployments/configure-a-build#corepack)
18:34:45.491 Running "install" command: pnpm install...
18:34:46.145 Scope: all 27 workspace projects
18:34:46.348 ../.. | Progress: resolved 1, reused 0, downloaded 0, added 0
18:34:46.490 ../.. | +1420 ++++++++++++++++++++++++++++
18:34:47.350 ../.. | Progress: resolved 1420, reused 0, downloaded 47, added 14
18:34:48.351 ../.. | Progress: resolved 1420, reused 0, downloaded 174, added 70
18:34:49.351 ../.. | Progress: resolved 1420, reused 0, downloaded 218, added 91
18:34:50.352 ../.. | Progress: resolved 1420, reused 0, downloaded 222, added 93
18:34:51.355 ../.. | Progress: resolved 1420, reused 0, downloaded 370, added 174
18:34:52.359 ../.. | Progress: resolved 1420, reused 0, downloaded 525, added 230
18:34:53.360 ../.. | Progress: resolved 1420, reused 0, downloaded 604, added 260
18:34:54.361 ../.. | Progress: resolved 1420, reused 0, downloaded 844, added 349
18:34:55.361 ../.. | Progress: resolved 1420, reused 0, downloaded 991, added 394
18:34:56.362 ../.. | Progress: resolved 1420, reused 0, downloaded 1105, added 448
18:34:57.363 ../.. | Progress: resolved 1420, reused 0, downloaded 1330, added 533
18:34:58.364 ../.. | Progress: resolved 1420, reused 0, downloaded 1418, added 603
18:34:59.364 ../.. | Progress: resolved 1420, reused 0, downloaded 1418, added 1024
18:35:00.364 ../.. | Progress: resolved 1420, reused 0, downloaded 1418, added 1257
18:35:01.265 ../.. | Progress: resolved 1420, reused 0, downloaded 1418, added 1420, done
18:35:02.155
18:35:02.155 dependencies:
18:35:02.155 + @object-ui/core 0.3.1 <- ../core
18:35:02.155 + @object-ui/react 0.3.1 <- ../react
18:35:02.155 + @object-ui/types 0.3.1 <- ../types
18:35:02.156 + @radix-ui/react-accordion 1.2.12
18:35:02.156 + @radix-ui/react-alert-dialog 1.1.15
18:35:02.156 + @radix-ui/react-aspect-ratio 1.1.8
18:35:02.156 + @radix-ui/react-avatar 1.1.11
18:35:02.156 + @radix-ui/react-checkbox 1.3.3
18:35:02.156 + @radix-ui/react-collapsible 1.1.12
18:35:02.156 + @radix-ui/react-context-menu 2.2.16
18:35:02.156 + @radix-ui/react-dialog 1.1.15
18:35:02.156 + @radix-ui/react-dropdown-menu 2.1.16
18:35:02.156 + @radix-ui/react-hover-card 1.1.15
18:35:02.156 + @radix-ui/react-label 2.1.8
18:35:02.156 + @radix-ui/react-menubar 1.1.16
18:35:02.156 + @radix-ui/react-navigation-menu 1.2.14
18:35:02.156 + @radix-ui/react-popover 1.1.15
18:35:02.157 + @radix-ui/react-progress 1.1.8
18:35:02.157 + @radix-ui/react-radio-group 1.3.8
18:35:02.157 + @radix-ui/react-scroll-area 1.2.10
18:35:02.157 + @radix-ui/react-select 2.2.6
18:35:02.157 + @radix-ui/react-separator 1.1.8
18:35:02.157 + @radix-ui/react-slider 1.3.6
18:35:02.157 + @radix-ui/react-slot 1.2.4
18:35:02.157 + @radix-ui/react-switch 1.2.6
18:35:02.157 + @radix-ui/react-tabs 1.1.13
18:35:02.157 + @radix-ui/react-toast 1.2.15
18:35:02.157 + @radix-ui/react-toggle 1.1.10
18:35:02.157 + @radix-ui/react-toggle-group 1.1.11
18:35:02.157 + @radix-ui/react-tooltip 1.2.8
18:35:02.157 + class-variance-authority 0.7.1
18:35:02.157 + clsx 2.1.1
18:35:02.157 + cmdk 1.1.1
18:35:02.158 + date-fns 4.1.0
18:35:02.158 + embla-carousel-react 8.6.0
18:35:02.158 + input-otp 1.4.2
18:35:02.158 + lucide-react 0.563.0
18:35:02.158 + next-themes 0.4.6
18:35:02.158 + react 19.2.3
18:35:02.158 + react-day-picker 9.13.0
18:35:02.158 + react-dom 19.2.3
18:35:02.158 + react-hook-form 7.71.1
18:35:02.158 + react-resizable-panels 4.5.2
18:35:02.158 + recharts 2.15.4
18:35:02.158 + sonner 2.0.7
18:35:02.158 + tailwind-merge 3.4.0
18:35:02.158 + tailwindcss-animate 1.0.7
18:35:02.158 + vaul 1.1.2
18:35:02.158
18:35:02.158 devDependencies:
18:35:02.159 + @storybook/addon-essentials 8.6.14
18:35:02.159 + @storybook/addon-interactions 8.6.14
18:35:02.159 + @storybook/addon-links 8.6.15
18:35:02.159 + @s...


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
objectui Ready Ready Preview, Comment Jan 28, 2026 10:52am
objectui-components Ready Ready Preview, Comment Jan 28, 2026 10:52am
objectui-crm-app Ready Ready Preview, Comment Jan 28, 2026 10:52am

Request Review

Copilot AI and others added 3 commits January 28, 2026 10:39
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Update pnpm version to 10.x for the project Fix Storybook build by ensuring workspace dependencies are built first Jan 28, 2026
Copilot AI requested a review from hotlong January 28, 2026 10:45
@hotlong hotlong marked this pull request as ready for review January 28, 2026 11:13
Copilot AI review requested due to automatic review settings January 28, 2026 11:13
@hotlong hotlong merged commit 74ace7c into main Jan 28, 2026
15 of 16 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures the @object-ui/components Storybook build succeeds on Vercel by compiling required workspace dependencies before Storybook bundles.

Changes:

  • Added a shared prebuild script that builds @object-ui/types, @object-ui/core, and @object-ui/react in order.
  • Wired pretest and prebuild-storybook to run the shared prebuild script.
  • Included @object-ui/types in the dependency build step for consistency.

"pretest": "pnpm run prebuild",
"test": "vitest run",
"type-check": "tsc --noEmit",
"lint": "eslint .",
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Storybook dev script (storybook) likely has the same workspace-resolution problem as build-storybook: stories import local renderers that import @object-ui/core at runtime, and @object-ui/core resolves to ./dist/index.js. In a clean checkout (no prior tsc), pnpm run storybook will still fail because there is no prestorybook hook to build the workspace deps first. Consider adding a prestorybook script that runs pnpm run prebuild (or otherwise ensuring deps are built before storybook dev).

Suggested change
"lint": "eslint .",
"lint": "eslint .",
"prestorybook": "pnpm run prebuild",

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

📦 Bundle Size Report

Package Size Gzipped
components (index.js) 1761.18KB 416.54KB
core (index.js) 0.51KB 0.28KB
data-objectstack (index.js) 4.42KB 1.47KB
fields (index.js) 53.83KB 11.57KB
layout (index.js) 12.26KB 3.83KB
plugin-aggrid (AgGridImpl-DKkq6v1B.js) 5.09KB 1.84KB
plugin-aggrid (index-B6NPAFZx.js) 15.66KB 4.51KB
plugin-aggrid (index.js) 0.18KB 0.15KB
plugin-calendar (index.js) 33.12KB 8.29KB
plugin-charts (AdvancedChartImpl-DJcN3TPx.js) 69.51KB 16.23KB
plugin-charts (BarChart-RKJxvg5Y.js) 535.74KB 134.11KB
plugin-charts (ChartImpl-CE1UGkNR.js) 8.78KB 3.11KB
plugin-charts (index-CTfEtwhn.js) 12.40KB 3.84KB
plugin-charts (index.js) 0.21KB 0.16KB
plugin-chatbot (index.js) 18.36KB 5.21KB
plugin-dashboard (index.js) 11.92KB 3.81KB
plugin-editor (MonacoImpl-B7ZgZJJG.js) 18.15KB 5.59KB
plugin-editor (index-Dl3HAAqu.js) 10.07KB 3.31KB
plugin-editor (index.js) 0.19KB 0.15KB
plugin-form (index.js) 14.43KB 4.64KB
plugin-gantt (index.js) 17.97KB 5.24KB
plugin-grid (index.js) 15.62KB 4.91KB
plugin-kanban (KanbanImpl-CUWM-JC-.js) 76.50KB 20.46KB
plugin-kanban (index-BV3FWhCb.js) 11.86KB 3.67KB
plugin-kanban (index.js) 0.18KB 0.15KB
plugin-map (index.js) 16.72KB 5.09KB
plugin-markdown (MarkdownImpl-BRkYjVWf.js) 256.79KB 64.50KB
plugin-markdown (index-D_CdfEXQ.js) 9.59KB 3.16KB
plugin-markdown (index.js) 0.19KB 0.15KB
plugin-timeline (index.js) 23.90KB 5.95KB
plugin-view (index.js) 16.24KB 4.77KB
react (SchemaRenderer.js) 1.44KB 0.73KB
react (index.js) 0.36KB 0.23KB
react (index.test.js) 0.34KB 0.26KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 0.20KB 0.18KB
types (base.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data.js) 0.20KB 0.18KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 0.34KB 0.25KB
types (layout.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (registry.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@github-actions
Copy link

✅ All checks passed!

  • ✅ Type check passed
  • ✅ Tests passed
  • ✅ Lint check completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants