-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade @objectstack to v0.6.1 and add runtime dependencies #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…encies Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the HotCRM monorepo to use @objectstack v0.6.1 across domain packages, adds the official runtime-related dependencies to the server package, and documents the current limitation around using @objectstack/runtime in an ESM environment.
Changes:
- Bumped
@objectstack/specfrom^0.6.0to^0.6.1in all domain packages and lockfile. - Added
@objectstack/core,@objectstack/runtime,@objectstack/objectql, and@objectstack/driver-memory^0.6.1dependencies to the server package and updated server banner/documentation to reflect the upgrade and current runtime status. - Added
UPGRADE_NOTES.mdand updatedREADME.mdto describe the 0.6.1 upgrade, known ESM issues with@objectstack/runtime, and the future migration path.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pnpm-lock.yaml |
Locks all upgraded @objectstack packages and new runtime-related dependencies at version 0.6.1, ensuring reproducible installs with the new stack. |
packages/core/package.json |
Updates @objectstack/spec dependency to ^0.6.1 for the core domain, aligning it with the new protocol version. |
packages/crm/package.json |
Bumps @objectstack/spec to ^0.6.1 so the CRM package uses the latest spec definitions. |
packages/support/package.json |
Updates @objectstack/spec to ^0.6.1 for the support domain to keep protocol versions consistent. |
packages/products/package.json |
Aligns the products package with @objectstack/spec ^0.6.1. |
packages/finance/package.json |
Moves the finance package to @objectstack/spec ^0.6.1 to match other domains. |
packages/ui/package.json |
Updates UI package to depend on @objectstack/spec ^0.6.1, ensuring UI metadata uses the latest spec. |
packages/server/package.json |
Adds @objectstack/core, @objectstack/runtime, @objectstack/objectql, and @objectstack/driver-memory as ^0.6.1 dependencies to prepare the server for using the official runtime. |
packages/server/src/server.ts |
Adds comments documenting the current use of the local ObjectQL implementation and the ESM issues with @objectstack/runtime@0.6.1, plus a banner line indicating the upgrade to v0.6.1. |
UPGRADE_NOTES.md |
Introduces detailed upgrade notes for @objectstack 0.6.1, including known ESM issues, migration path to the official runtime, and current testing status. |
README.md |
Updates the public-facing description to explicitly reference @objectstack/spec v0.6.1, reflecting the new protocol version used by the project. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Description
Upgraded @objectstack/spec from 0.6.0 to 0.6.1 across all packages. Added @objectstack/runtime dependencies (core, runtime, objectql, driver-memory) to server package, though ESM compatibility issues in published packages prevent immediate runtime adoption.
Type of Change
Changes Made
Dependency Upgrades
@objectstack/spec: ^0.6.0 → ^0.6.1 (core, crm, support, products, finance, ui packages)@objectstack/core,@objectstack/runtime,@objectstack/objectql,@objectstack/driver-memoryat ^0.6.1Documentation
UPGRADE_NOTES.mddocumenting ESM compatibility issues in @objectstack/runtime@0.6.1 (missing.jsextensions in imports)server.tsexplaining current state and future migration pathRuntime Integration Readiness
Server architecture prepared for kernel-based initialization when upstream packages are fixed:
Current implementation continues using local ObjectQL from
@hotcrm/coreuntil upstream resolves ESM compatibility.Testing
npm test)npm run lint)npm run build)Screenshots
N/A - Infrastructure upgrade with no UI changes
Checklist
Additional Notes
ESM Compatibility Blocker: @objectstack/runtime@0.6.1 and @objectstack/objectql@0.6.1 have missing
.jsextensions in their ES module imports, causing Node.js runtime errors. Dependencies are installed and ready; migration to official runtime requires upstream package fixes. SeeUPGRADE_NOTES.mdfor details.Migration Impact: None. Server continues using existing ObjectQL implementation. Future migration to kernel-based runtime will be seamless once upstream packages are fixed.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.