-
Notifications
You must be signed in to change notification settings - Fork 25
Feat rebuild ANTLR bindings #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using openjdk-19-jre-headless $ sha256sum antlr-4.13.1-complete.jar bc13a9c57a8dd7d5196888211e5ede657cb64a3ce968608697e4f668251a8487 antlr-4.13.1-complete.jar Building the bindings java -jar ./antlr-4.13.1-complete.jar -Dlanguage=Python3 STIXPattern.g4 -visitor -o ./stix2patterns/v21/grammars java -jar ./antlr-4.13.1-complete.jar -Dlanguage=Python3 STIXPattern.g4 -visitor -o ./stix2patterns/v20/grammars Files taken from https://github.com/oasis-open/cti-stix2-json-schemas/blob/stix2.0/pattern_grammar/STIXPattern.g4 https://github.com/oasis-open/cti-stix2-json-schemas/blob/stix2.1/pattern_grammar/STIXPattern.g4 $ sha256sum STIXPattern.g4* a5fab115c8973680f13274113ba1d9c1fe5708b00805a06644c7ce717c42ff19 STIXPattern.g4.20 b6429e8fed902133d2409d86c906b0c9dbaa4a54536023997ee73b460876b228 STIXPattern.g4.21
|
@vEpiphyte Hi! I've opened PR #100 which builds on similar work to this PR. It uses ANTLR 4.13.2 (vs 4.13.1 here), adds Python 3.13 support, includes an automated regeneration script, and updates all three grammar directories. I also fixed the v20 inspector to handle the TimestampLiteral API change. Happy to coordinate so we don't duplicate effort. If you'd like, we could consolidate the work into one PR. Let me know your thoughts! |
|
@brianatdetections I will close this in favor of your PR. The only real "feature" that mine had over #100 was the removal of the I'll open a separate PR that cherry picks ec5b7be and then close this PR once that is available. |
Binding regeneration:
Using openjdk-19-jre-headless
Files taken from
https://github.com/oasis-open/cti-stix2-json-schemas/blob/stix2.0/pattern_grammar/STIXPattern.g4
https://github.com/oasis-open/cti-stix2-json-schemas/blob/stix2.1/pattern_grammar/STIXPattern.g4
Bindings were committed as is.
The test suite for https://github.com/oasis-open/cti-pattern-matcher and https://github.com/oasis-open/cti-stix-validator pass with these updated bindings.
The tox suite seems to fail on a packaing step. That is unrelated to this PR.
Closes #84