Update to ANTLR 4.13 and add Python 3.13 support #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Author
|
recheck |
- Update antlr4-python3-runtime dependency from ~=4.9.0 to ~=4.13.0 - Regenerate all parser files with ANTLR 4.13.2 (12 files across 3 locations) - Add Python 3.13 to test matrix and classifiers - Add automated grammar regeneration script (scripts/regenerate_grammars.sh) - Update v20 inspector to use TimestampLiteral (grammar API change) - Update v20 tests to use timestamp literal syntax (t'...') - Fix documentation to reference Python3 instead of Python2 for ANTLR - Update GitHub Actions to latest versions (checkout@v4, setup-python@v5) - Bump version to 2.1.0 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
brianatdetections
force-pushed
the
antlr-4.13-upgrade
branch
from
d1a5fa1 to
29eac1a
Compare
Author
|
@ejratl @clenk @chisholm @JasonKeirstead @sparrell Hi maintainers! This PR updates ANTLR to 4.13.2 and adds Python 3.13 support. Key improvements over the existing PR #96:
All 177 tests pass, CLA is signed, and CI is green. Would appreciate a review when you have time. Happy to address any feedback! |
|
@brianatdetections Nice work! It would probably be best to include Python 3.14 as a supported target as well; since that would be one more package pulled into support for the modern world. I haven't looked to see about antlr4 version support for 3.14 is; so that could be a issue there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the STIX Pattern Validator to use ANTLR 4.13.x and adds Python 3.13 support.
Changes
antlr4-python3-runtimedependency from~=4.9.0to~=4.13.0scripts/regenerate_grammars.shfor easy grammar regenerationBreaking Change Note
The upstream grammar now requires timestamp literals with the
tprefix for STARTSTOP qualifiers (e.g.,START t'2024-01-01T00:00:00Z'instead ofSTART '2024-01-01T00:00:00Z'). This aligns with the current STIX 2.1 specification. The v20 inspector and tests have been updated accordingly.Test Plan
Files Changed
CLA
I have signed the Individual Contributor License Agreement.
🤖 Generated with Claude Code