Skip to content

Preparing for release 1.6.0 #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CharliePoole wants to merge 1 commit into from
Closed

Preparing for release 1.6.0 #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions recipe/nuget-package.cake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,14 @@ public class NuGetPackage : PackageDefinition

public override void BuildPackage()
{
Console.WriteLine($"Building package from {PackageSource}");
Copy link
Copy Markdown
Member

@veleek veleek May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment line will log Building package from when PackageSource Is null or empty, and then line 112 will log Building package again, but only when PackageSource ends with .nuspec?

if (string.IsNullOrEmpty(PackageSource))
_context.NuGetPack(NuGetPackSettings);
else if (PackageSource.EndsWith(".nuspec"))
{
Console.WriteLine("Building Package");
_context.NuGetPack(PackageSource, NuGetPackSettings);
}
else if (PackageSource.EndsWith(".csproj"))
_context.MSBuild(PackageSource,
new MSBuildSettings
Expand Down
2 changes: 1 addition & 1 deletion recipe/versioning.cake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class BuildVersion
// NOTE: This is complicated because (1) the user may have specified
// the package version on the command-line and (2) GitVersion may
// or may not be available. We'll work on solving (2) by getting
// GitVersion to run for us on Linux, but (1) will alwas remain.
// GitVersion to run for us on Linux, but (1) will always remain.
//
// We simplify things a by figuring out the full package version and
// then parsing it to provide information that is used in the build.
Expand Down
Loading