Preparing for release 1.6.0#103
Conversation
|
|
||
| public override void BuildPackage() | ||
| { | ||
| Console.WriteLine($"Building package from {PackageSource}"); |
There was a problem hiding this comment.
This comment line will log Building package from when PackageSource Is null or empty, and then line 112 will log Building package again, but only when PackageSource ends with .nuspec?
| Console.WriteLine($"Building package from {PackageSource}"); | ||
| if (string.IsNullOrEmpty(PackageSource)) | ||
| _context.NuGetPack(NuGetPackSettings); | ||
| else if (PackageSource.EndsWith(".nuspec")) | ||
| { | ||
| Console.WriteLine("Building Package"); | ||
| _context.NuGetPack(PackageSource, NuGetPackSettings); | ||
| } | ||
| else if (PackageSource.EndsWith(".csproj")) | ||
| _context.MSBuild(PackageSource, | ||
| new MSBuildSettings | ||
| { | ||
| Target = "pack", | ||
| Verbosity = BuildSettings.MSBuildVerbosity, | ||
| Configuration = BuildSettings.Configuration, | ||
| PlatformTarget = PlatformTarget.MSIL, | ||
| //AllowPreviewVersion = BuildSettings.MSBuildAllowPreviewVersion | ||
| }.WithProperty("Version", PackageVersion)); | ||
| else | ||
| throw new ArgumentException( | ||
| $"Invalid package source specified: {PackageSource}", "source"); |
There was a problem hiding this comment.
| if (string.IsNullOrEmpty(PackageSource)) | |
| { | |
| Console.WriteLine($"Building package with no source"); | |
| _context.NuGetPack(NuGetPackSettings); | |
| } | |
| else if (PackageSource.EndsWith(".nuspec")) | |
| { | |
| Console.WriteLine("Building Package from spec {PackageSource}"); | |
| _context.NuGetPack(PackageSource, NuGetPackSettings); | |
| } | |
| else if (PackageSource.EndsWith(".csproj")) | |
| { | |
| Console.WriteLine("Building Package from project {PackageSource}"); | |
| _context.MSBuild(PackageSource, | |
| new MSBuildSettings | |
| { | |
| Target = "pack", | |
| Verbosity = BuildSettings.MSBuildVerbosity, | |
| Configuration = BuildSettings.Configuration, | |
| PlatformTarget = PlatformTarget.MSIL, | |
| //AllowPreviewVersion = BuildSettings.MSBuildAllowPreviewVersion | |
| }.WithProperty("Version", PackageVersion)); | |
| } | |
| else | |
| throw new ArgumentException( | |
| $"Invalid package source specified: {PackageSource}", "source"); |
There was a problem hiding this comment.
@veleek Thanks for the review... I got it after merging but I had already made a similar change.
FYI... MyGet is broken or at least seriously unresponsive and causing a lot of failures. The CI build for the pull you reviewed failed for that reason. Consequently, I'm doing a lot of updates by passing the normal process with the aim of eliminating use of MyGet entirely. Betas and higher releases go to nuget.org which is extremely reliable.
It's rare for anyone to review the recipe updates. So double thanks!
There was a problem hiding this comment.
No worries, I don't have much time to spend on this stuff, but I've been working through some NUnit issues so I felt like I could justify spending some time looking at NUnit code. :)
2 participants
No description provided.