-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
test: replace deprecated regex test assertions in http trailers test #60831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replace deprecated regex test assertions in http trailers test #60831
Conversation
? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60831 +/- ##
=======================================
Coverage 88.54% 88.54%
=======================================
Files 703 703
Lines 208259 208259
Branches 40170 40167 -3
=======================================
+ Hits 184405 184406 +1
- Misses 15859 15870 +11
+ Partials 7995 7983 -12 🚀 New features to boost your workflow:
|
|
@lpinca Thanks for pointing that out . I've removed that line to avoid implying any official deprecation. |
|
Landed in 23c58f0 |
PR-URL: #60831 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This PR updates
test/parallel/test-http-set-trailers.jsto align with the recent test modernization work happening across the Node.js codebase. Maintainers have been gradually replacing olderassert.ok(/regex/.test(...))patterns with clearer, more explicit helpers such asassert.match()andassert.doesNotMatch().This PR applies that same modernization to this test file.
What was changed
HTTP/1.0 test
Previously:
Updated to:
HTTP/1.1 test
Previously:
Updated to:
Why this change
Additional notes