Update CI matrix to test Node.js 26 and fix diagnostics compatibility#762
Draft
Update CI matrix to test Node.js 26 and fix diagnostics compatibility#762
Conversation
Agent-Logs-Url: https://github.com/node-modules/urllib/sessions/692edcef-0a0f-41c0-a522-f40d6b360f93 Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
fengmk2
May 7, 2026 02:41
View session
commit: |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #762 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 10 10
Lines 730 730
Branches 228 228
=======================================
Hits 691 691
Misses 36 36
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@copilot ci fails |
Agent-Logs-Url: https://github.com/node-modules/urllib/sessions/56c2c61e-4d23-4d63-ba42-6bf3dc1dc552 Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Agent-Logs-Url: https://github.com/node-modules/urllib/sessions/56c2c61e-4d23-4d63-ba42-6bf3dc1dc552 Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Contributor
Author
Fixed in ce8ed51. I investigated the failing Node 26 jobs, updated the default HttpClient dispatcher path to avoid the global undici dispatcher on Node 26, and tightened the diagnostics-channel tests so they ignore events without handler opaque state. Targeted diagnostics tests now pass on both Node 22 and Node 26 locally. |
Copilot
AI
changed the title
Update CI matrix to test Node.js 26
Update CI matrix to test Node.js 26 and fix diagnostics compatibility
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI workflow was still testing Node.js 25 in the cross-platform test matrix. This updates the matrix to track Node.js 26 and includes the compatibility fix needed for the diagnostics tests to pass on Node.js 26.
CI matrix
25with26in.github/workflows/nodejs.ymlNode 26 diagnostics compatibility
HttpClientto use a dedicated undiciAgentby default instead of relying on the global dispatchertest/diagnostics_channel.test.tsto ignore diagnostics events that do not include handler opaque stateScope