Skip to content

Update CI matrix to test Node.js 26 and fix diagnostics compatibility#762

Draft
Copilot wants to merge 3 commits intomasterfrom
copilot/update-nodejs-version-to-v26
Draft

Update CI matrix to test Node.js 26 and fix diagnostics compatibility#762
Copilot wants to merge 3 commits intomasterfrom
copilot/update-nodejs-version-to-v26

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

The CI workflow was still testing Node.js 25 in the cross-platform test matrix. This updates the matrix to track Node.js 26 and includes the compatibility fix needed for the diagnostics tests to pass on Node.js 26.

  • CI matrix

    • Replaced 25 with 26 in .github/workflows/nodejs.yml
    • Keeps the existing OS coverage unchanged while moving the Node.js version set forward
  • Node 26 diagnostics compatibility

    • Updated HttpClient to use a dedicated undici Agent by default instead of relying on the global dispatcher
    • Adjusted test/diagnostics_channel.test.ts to ignore diagnostics events that do not include handler opaque state
  • Scope

    • Includes a small runtime compatibility fix plus targeted test updates
    • No package metadata changes
strategy:
  matrix:
    os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
    node: ['22', '24', '26']

Agent-Logs-Url: https://github.com/node-modules/urllib/sessions/692edcef-0a0f-41c0-a522-f40d6b360f93

Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 7, 2026

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@762

commit: ce8ed51

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 7, 2026

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@762

commit: 754babc

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.65%. Comparing base (cea1cd7) to head (754babc).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #762   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files          10       10           
  Lines         730      730           
  Branches      228      228           
=======================================
  Hits          691      691           
  Misses         36       36           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented May 7, 2026

@copilot ci fails

Copilot AI and others added 2 commits May 7, 2026 04:03
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 7, 2026

@copilot ci fails

Fixed in ce8ed51. I investigated the failing Node 26 jobs, updated the default HttpClient dispatcher path to avoid the global undici dispatcher on Node 26, and tightened the diagnostics-channel tests so they ignore events without handler opaque state. Targeted diagnostics tests now pass on both Node 22 and Node 26 locally.

Copilot AI changed the title Update CI matrix to test Node.js 26 Update CI matrix to test Node.js 26 and fix diagnostics compatibility May 7, 2026
Copilot finished work on behalf of fengmk2 May 7, 2026 04:05
Copilot AI requested a review from fengmk2 May 7, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants