Convert "spawning recruitment" to "stock recruitment" #174
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Code Metrics Report
Code coverage of files in pull request scope (77.9%)
Reported by octocov |
There was a problem hiding this comment.
Pull request overview
This PR renames the plot_spawn_recruitment function to plot_stock_recruitment to align with terminology standards per issue #172. The change updates the function name, documentation, and all references throughout the codebase to use "stock recruitment" instead of "spawning recruitment".
- Renamed function from
plot_spawn_recruitmenttoplot_stock_recruitment - Updated documentation titles and descriptions to reflect "Stock Recruit" terminology
- Updated all function calls and references in tests and comments
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-plot_stock_recruitment.R | Updated test names and function calls to use new function name |
| man/plot_stock_recruitment.Rd | Updated roxygen-generated documentation with new function name and terminology |
| R/utils_rda.R | Updated comments referencing the renamed function |
| R/save_all_plots.R | Updated comments referencing the renamed function |
| R/plot_stock_recruitment.R | Renamed function definition and updated all documentation strings |
| NAMESPACE | Updated export statement to reflect new function name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Schiano-NOAA
left a comment
Schiano-NOAA
left a comment
There was a problem hiding this comment.
The changes you made look good. Are there any instances where its referred to incorrectly in the caption or alt text? I requested a copilot review because it might be able to find these things.
I checked and it looked like the caps/alt text were already correct |
|
Great! Then good to merge |
Convert "spawning recruitment" to "stock recruitment" as per #172