Update amulety modules #9674
Open
Update amulety modules #9674
+575
−762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joon-Klaps
reviewed
Jan 16, 2026
Contributor
Joon-Klaps
left a comment
Joon-Klaps
left a comment
There was a problem hiding this comment.
There are some rules on deprecating modules. https://nf-co.re/docs/guidelines/components/module_deprecation
Think it might be better to make a amulety2? What do you think?
Member
Author
|
Ah thanks, I wasn't aware of this. I don't think it's needed to use AMULETY2, since the deprecated commands are no longer available. Instead of deleting the old modules I will deprecate them. |
Member
Author
|
Hi @Joon-Klaps I've deprecated the old modules now instead of just removing them. Let me know if the PR now looks good to you when you have a minute |
Joon-Klaps
reviewed
Jan 19, 2026
Contributor
Joon-Klaps
left a comment
Joon-Klaps
left a comment
There was a problem hiding this comment.
Minor suggestions, everything else looks good to me!
Co-authored-by: Joon Klaps <joon.klaps@kuleuven.be>
Co-authored-by: Joon Klaps <joon.klaps@kuleuven.be>
Co-authored-by: Joon Klaps <joon.klaps@kuleuven.be>
Co-authored-by: Joon Klaps <joon.klaps@kuleuven.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update amulety modules: in amulety>=2.0 the command syntax and subcommands have changed and I updated the nf-core modules are accordingly.