Open
Conversation
LouisLeNezet
reviewed
Apr 6, 2026
Contributor
LouisLeNezet
left a comment
LouisLeNezet
left a comment
There was a problem hiding this comment.
Just a few questions but good to go otherwise !
|
|
||
| output: | ||
| tuple val(meta), path("*.vcf.gz") , emit: vcf | ||
| tuple val(meta), path("*.vcf.gz.tbi") , emit: tbi , optional: true |
Contributor
There was a problem hiding this comment.
In which case is it omitted ?
Contributor
Author
There was a problem hiding this comment.
Sorry I did not understand this comment
Contributor
There was a problem hiding this comment.
I was just wondering if the tbi output is ever omitted ?
Isn't it always produced ?
LouisLeNezet
approved these changes
Apr 7, 2026
Contributor
LouisLeNezet
left a comment
LouisLeNezet
left a comment
There was a problem hiding this comment.
Just a small deletion needed, but ready to go otherwise !
Would it be also possible to have a non-stub test with the optional outputs ?
Comment on lines
+12
to
+14
| tag "wget" | ||
| tag "xz/decompress" | ||
| tag "untar" |
Contributor
There was a problem hiding this comment.
I guess these modules are no more needed ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For nf-core/phaseimpute#282