Add metamap for input/output in stringtie/merge#11108
Open
Odulhin wants to merge 7 commits intonf-core:masterfrom
Open
Add metamap for input/output in stringtie/merge#11108Odulhin wants to merge 7 commits intonf-core:masterfrom
Odulhin wants to merge 7 commits intonf-core:masterfrom
Conversation
dialvarezs
reviewed
Apr 2, 2026
famosab
reviewed
Apr 2, 2026
Contributor
famosab
left a comment
famosab
left a comment
There was a problem hiding this comment.
Thank you for your contribution to nf-core! We really appreciate it. I added a few comments to your PR. Good work updating this module to adhere more to the nf-core guidelines
lindenb
reviewed
Apr 2, 2026
lindenb
reviewed
Apr 2, 2026
added 3 commits
April 2, 2026 14:55
famosab
reviewed
Apr 7, 2026
Comment on lines
+12
to
+13
| tuple val(meta), path(gtf) | ||
| tuple val(meta2), path(annotation_gtf) |
Contributor
There was a problem hiding this comment.
Can we put all these inputs into one tuple? That will make sure you're sure that EVERY time everything comes together in the right combination.
Contributor
Author
There was a problem hiding this comment.
I've made the necessary changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #8686