-
Notifications
You must be signed in to change notification settings - Fork 1k
Big slice imp modules #11034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Big slice imp modules #11034
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
15d27bd
Updating bigslice
SkyLexS 4edc137
[automated] Fix linting with Prettier
nf-core-bot 2d142cf
Linting and modifing the bigslice version emiting
SkyLexS 4e0e985
Updated the bigslice module
SkyLexS c321854
Merge branch 'master' into big_slice_imp_modules
SkyLexS bfedf4c
fixing versioning
SkyLexS f8542ca
resolved export_tsv support and other parameters and fix parameter de…
SkyLexS 572c806
Merge branch 'master' into big_slice_imp_modules
SkyLexS 4de6d51
collect all samples cross-run
SkyLexS ed38681
Merge branch 'master' into big_slice_imp_modules
SkyLexS cbd886a
updating snapshot
SkyLexS f281cf2
Merge branch 'master' into big_slice_imp_modules
SkyLexS 59c156d
updating snapshot yet again
SkyLexS eb1d391
updating snapshot
SkyLexS 8814ea4
Merge branch 'master' into big_slice_imp_modules
SkyLexS 90fac06
add tsv emit, snapshot file names
SkyLexS a3e6cb4
updated tests
SkyLexS 4f9ca65
Merge branch 'master' into big_slice_imp_modules
SkyLexS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,16 +67,76 @@ nextflow_process { | |
| [ meta, gbk_files ] | ||
| } | ||
| input[1] = UNTAR_HMMDB.out.untar.map{ it -> it[1] } | ||
| input[2] = false | ||
| """ | ||
| } | ||
| } | ||
|
|
||
| then { | ||
| assert process.success | ||
| def resultDir = file(process.out.output[0][1]) | ||
| def allNames = [] | ||
| def tmpFaCount = 0 | ||
| resultDir.eachFileRecurse { f -> | ||
| if (!f.isDirectory()) { | ||
| def rel = resultDir.toPath().relativize(f.toPath()).toString() | ||
| if (rel.startsWith('tmp/') || rel.startsWith('tmp\\')) { | ||
| if (f.name.endsWith('.fa')) tmpFaCount++ | ||
| } else { | ||
| allNames.add(f.name) | ||
| } | ||
| } | ||
| } | ||
| assertAll( | ||
| { assert resultDir.isDirectory() }, | ||
| { assert tmpFaCount > 0 }, | ||
| { assert snapshot( | ||
| allNames.sort(), | ||
| process.out.findAll { key, val -> key.startsWith("versions")} | ||
| ).match() } | ||
|
Comment on lines
+91
to
+96
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add other files to this snapshot as well? Ideally we want all outputs to be at least present by name in the snapshot. |
||
| ) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| test("streptomyces_coelicolor - bigslice - gbk - export_tsv") { | ||
|
|
||
| when { | ||
| process { | ||
| """ | ||
| // Flatten the GBK directory into a list of individual GBK files with meta | ||
| input[0] = UNTAR_GBK.out.untar.map { meta, dir -> | ||
| def gbk_files = [] | ||
| dir.eachFileRecurse { if (it.name.endsWith('.gbk')) gbk_files << it } | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| [ meta, gbk_files ] | ||
| } | ||
| input[1] = UNTAR_HMMDB.out.untar.map{ it -> it[1] } | ||
| input[2] = true | ||
| """ | ||
| } | ||
| } | ||
|
|
||
| then { | ||
| assert process.success | ||
| def resultDir = file(process.out.output[0][1]) | ||
| def allNames = [] | ||
| def tmpFaCount = 0 | ||
| resultDir.eachFileRecurse { f -> | ||
| if (!f.isDirectory()) { | ||
| def rel = resultDir.toPath().relativize(f.toPath()).toString() | ||
| if (rel.startsWith('tmp/') || rel.startsWith('tmp\\')) { | ||
| if (f.name.endsWith('.fa')) tmpFaCount++ | ||
| } else { | ||
| allNames.add(f.name) | ||
| } | ||
| } | ||
| } | ||
| assertAll( | ||
| { assert resultDir.isDirectory() }, | ||
| { assert tmpFaCount > 0 }, | ||
| { assert file(process.out.tsv[0][1]).isDirectory() }, | ||
| { assert snapshot( | ||
| file(process.out.db[0][1]).name, | ||
| process.out.fa[0][1].size(), | ||
| allNames.sort(), | ||
| process.out.findAll { key, val -> key.startsWith("versions")} | ||
| ).match() } | ||
| ) | ||
|
|
@@ -98,6 +158,7 @@ nextflow_process { | |
| [ meta, gbk_files ] | ||
| } | ||
| input[1] = UNTAR_HMMDB.out.untar.map{ it -> it[1] } | ||
| input[2] = false | ||
| """ | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.