Skip to content

fix(openmetrics): fix label names and add test for them #57764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Altahrim wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(openmetrics): fix label names and add test for them #57764

Altahrim wants to merge 1 commit into from
+24 −6

Conversation

@Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Jan 23, 2026

Summary

Enforce correct formatting for labels

label-name = label-name-initial-char *label-name-char
label-name-char = label-name-initial-char / DIGIT
label-name-initial-char = ALPHA / "_"

Checklist

@Altahrim Altahrim added this to the Nextcloud 34 milestone Jan 23, 2026
@Altahrim Altahrim self-assigned this Jan 23, 2026
@Altahrim Altahrim requested a review from a team as a code owner January 23, 2026 16:15
@Altahrim Altahrim requested review from ArtificialOwl, icewind1991, nfebe and salmart-dev and removed request for a team January 23, 2026 16:15
@Altahrim Altahrim added bug 3. to review Waiting for reviews labels Jan 23, 2026
@Altahrim
Copy link
Collaborator Author

Altahrim commented Jan 23, 2026

/backport to stable33 please

CarlSchwan
CarlSchwan reviewed Jan 23, 2026
View reviewed changes
tests/lib/OpenMetrics/Exporters/ExporterTestCase.php Outdated
$this->assertNotEmpty($this->metrics);
}

public function testValidNames() {
Copy link
Member

@CarlSchwan CarlSchwan Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function testValidNames() {
public function testValidNames(): void {

@Altahrim
fix(openmetrics): fix label names and add test for them
481fe15 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim force-pushed the fix/openmetrics_labels branch from 0753717 to 481fe15 Compare January 24, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

@Altahrim Altahrim

Labels

3. to review Waiting for reviews backport-request bug

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

3 participants

@Altahrim @CarlSchwan