Skip to content

fix: restore sender copy-to-clipboard and fix thread subject alignment #12966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sturlan wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −8
Open

fix: restore sender copy-to-clipboard and fix thread subject alignment #12966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Thread.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,8 @@ export default {
// initial width
width: 0;
// while scrolling, the back button overlaps with subject on small screen
// 66px to allign with the sender Envelope -> 8px margin + 2px border+ avatar -> 40px width + envelope__header -> 8px padding + sender-> margin 8px
padding-inline-start: 66px;
// envelope margin (2×baseline) + border (2px) + header padding (--border-radius-container) + avatar (10×baseline) + sender margin (2×baseline)
padding-inline-start: calc(var(--default-grid-baseline) * 14 + var(--border-radius-container) + 2px);
// grow and try to fill 100%
flex: 1 1 auto;
background: var(--color-main-background);
Expand Down
20 changes: 14 additions & 6 deletions src/components/ThreadEnvelope.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,11 @@
<ChevronUpIcon v-if="showRecipients" :size="16" />
<ChevronDownIcon v-else :size="16" />
</button>
<p
v-else-if="expanded"
class="sender__email"
:style="{ color: senderEmailColor }">
{{ senderEmail }}
</p>
<RecipientBubble
v-else-if="expanded && envelope.from && envelope.from[0]"
:email="envelope.from[0].email"
:label="envelope.from[0].label"
:size="24" />
<div v-if="hasChangedSubject" class="subline">
{{ cleanSubject }}
</div>
Expand Down Expand Up @@ -287,6 +286,15 @@
</div>
</div>
<div v-if="expanded && showRecipients" class="envelope__recipients">
<div v-if="envelope.from && envelope.from.length" class="recipients">
<span class="recipients__label">{{ t('mail', 'From:') }}</span>
<RecipientBubble
v-for="recipient in envelope.from"
:key="recipient.email"
:email="recipient.email"
:label="recipient.label"
:size="24" />
</div>
<div v-if="envelope.to && envelope.to.length" class="recipients">
<span class="recipients__label">{{ t('mail', 'To:') }}</span>
<RecipientBubble
Expand Down