fix: restore sender copy-to-clipboard and fix thread subject alignment#12966
Open
sturlan wants to merge 1 commit into
Open
fix: restore sender copy-to-clipboard and fix thread subject alignment#12966sturlan wants to merge 1 commit into
sturlan wants to merge 1 commit into
Conversation
- Replace <p class="sender__email"> with RecipientBubble when expanded and hasRecipients is false, so clicking the sender email always opens the contact popover (reply, add to contact, copy to clipboard) - Add a From: row with RecipientBubble at the top of the expanded recipients section, restoring copy-to-clipboard for the sender when To/Cc/Bcc recipients are present (fixes nextcloud#12952) - Fix #mail-thread-header-fields padding-inline-start from the hardcoded 66px to calc(var(--default-grid-baseline)*14 + var(--border-radius-container) + 2px) to account for the --border-radius-container header padding introduced in PR nextcloud#12666 (fixes nextcloud#12946) Follows up on PR nextcloud#12666. AI-assisted: Claude Code (claude-sonnet-4-6) Signed-off-by: Darko Sturlan <darko.sturlan@gmail.com>
|
Thanks for opening your first pull request in this repository! ✌️ |
jancborchardt
requested changes
May 21, 2026
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
According to the screenshots, the alignment is not fully fixed:
- The people chips of "To" and "Cc" should have same indentation as those of "From"
- The horizontal whitespace between the chips should be the same as the vertical whitespace between the chips
- There's very little padding on the right of the inside of the chips
@nimishavijay for review as well
Member
|
/backport to stable5.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #12666, fixing two regressions it introduced.
#12952 — Lost ability to copy sender email to clipboard
Before #12666 the sender email was rendered as a
RecipientBubble(contact popover with Reply / Add to Contact / Copy to clipboard). #12666 replaced it with a plain<button>or<p>— no popover in either case.Fix:
<p class="sender__email">withRecipientBubblefor the no-recipients case (sender email always clickable when expanded)RecipientBubbleat the top of the expanded recipients section, restoring the contact popover when To/Cc/Bcc are present#12946 — Regressed thread subject alignment
#mail-thread-header-fieldshadpadding-inline-start: 66px, computed assumingenvelope__headerhad 8 px of left padding. #12666 changed that padding from--border-radius-element(8 px) to--border-radius-container(12 px),leaving the sticky header 4 px short.
Fix:
Test plan
Fixes #12946
Fixes #12952