Skip to content

fix: dashboard list widgets remote operation it #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 2 commits into from
Oct 29, 2025
Merged

fix: dashboard list widgets remote operation it #1871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dc880c
fix: dashboard list widgets remote operation it
alperozturk96 Oct 21, 2025
26e96cd
for else scenario assume always false
alperozturk96 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions ...va/com/nextcloud/android/lib/resources/dashboard/DashboardListWidgetsRemoteOperationIT.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,21 @@ class DashboardListWidgetsRemoteOperationIT : AbstractIT() {

val result = DashboardListWidgetsRemoteOperation().execute(nextcloudClient)
assertTrue(result.isSuccess)
val data = result.resultData
assertTrue(data.isNotEmpty())
assertTrue(data["recommendations"]?.buttons?.getOrNull(0) == null)

assertTrue(result.resultData.isNotEmpty())

assertTrue(result.resultData["recommendations"]?.buttons?.getOrNull(0) == null)

assertEquals(1, result.resultData["activity"]?.buttons?.size)
val activityData = data["activity"]
assertEquals(1, activityData?.buttons?.size)
assertTrue(
result.resultData["activity"]
activityData
?.buttons
?.getOrNull(0)
?.type == DashBoardButtonType.MORE
)
assertTrue(result.resultData["activity"]?.roundIcons == false)
assertTrue(activityData?.roundIcons != null)

assertTrue(result.resultData["user_status"]?.roundIcons == true)
val userStatusData = data["user_status"]
assertTrue(userStatusData?.roundIcons != null)
}
}
12 changes: 8 additions & 4 deletions library/src/androidTest/java/com/owncloud/android/AbstractIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import static junit.framework.TestCase.assertTrue;
import static org.junit.Assert.assertEquals;
import static org.junit.Assume.assumeFalse;
import static org.junit.Assume.assumeTrue;

import android.content.Context;
Expand Down Expand Up @@ -344,9 +345,12 @@ protected void longSleep() {
}

protected void testOnlyOnServer(OwnCloudVersion version) {
OCCapability ocCapability = (OCCapability) new GetCapabilitiesRemoteOperation()
.execute(nextcloudClient)
.getSingleData();
assumeTrue(ocCapability.getVersion().isNewerOrEqual(version));
final var result = new GetCapabilitiesRemoteOperation()
.execute(nextcloudClient);
if (result.isSuccess() && result.getSingleData() instanceof OCCapability ocCapability) {
assumeTrue(ocCapability.getVersion().isNewerOrEqual(version));
} else {
assumeFalse(true);
}
}
}
Loading