Skip to content

Conversation

@alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented Oct 21, 2025

Fixes

Since activity round icons doesn't have to be false for all users? @tobiasKaminsky

Screenshot 2025-10-21 at 14 08 47
java.lang.RuntimeException: Accessing result data after operation failed!
    at com.owncloud.android.lib.common.operations.RemoteOperationResult.getSingleData(RemoteOperationResult.java:544)
    at com.owncloud.android.AbstractIT.testOnlyOnServer(AbstractIT.java:349)
    at com.nextcloud.android.lib.resources.dashboard.DashboardListWidgetsRemoteOperationIT.list(DashboardListWidgetsRemoteOperationIT.kt:20)
    at java.lang.reflect.Method.invoke(Native Method)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at androidx.test.internal.runner.junit4.statement.RunAfters.evaluate(RunAfters.java:61)
    at com.owncloud.android.RetryTestRule$statement$1.evaluate(RetryTestRule.kt:40)
    at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
    at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
    at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
    at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
    at org.junit.runners.Suite.runChild(Suite.java:128)
    at org.junit.runners.Suite.runChild(Suite.java:27)
    at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
    at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
    at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
    at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
    at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
    at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:68)
    at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
    at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:467)
    at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2624)

@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.02%. Comparing base (92c83f1) to head (26e96cd).
⚠️ Report is 142 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1871      +/-   ##
============================================
- Coverage     49.15%   49.02%   -0.14%     
- Complexity     1104     1108       +4     
============================================
  Files           234      234              
  Lines          8570     8561       -9     
  Branches       1120     1125       +5     
============================================
- Hits           4213     4197      -16     
- Misses         3747     3749       +2     
- Partials        610      615       +5     

see 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tobiasKaminsky

This comment was marked as resolved.

@alperozturk96 alperozturk96 force-pushed the fix/dashboard-list-widgets-remote-operation-it branch from 85af894 to 7fc38d6 Compare October 22, 2025 11:43
@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@alperozturk96
Copy link
Contributor Author

@AndyScherzinger @tobiasKaminsky Can we merge this PR? Since it is affecting other PRs.

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/dashboard-list-widgets-remote-operation-it branch from 7fc38d6 to 26e96cd Compare October 27, 2025 09:31
@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@alperozturk96
Copy link
Contributor Author

@AndyScherzinger @tobiasKaminsky Can we merge this PR? Since affecting other PRs as well.

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@alperozturk96
Copy link
Contributor Author

@AndyScherzinger Yes, but I can't still merge with approval as well.

@AndyScherzinger AndyScherzinger merged commit 22b6fb2 into master Oct 29, 2025
17 of 18 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/dashboard-list-widgets-remote-operation-it branch October 29, 2025 14:23
@AndyScherzinger AndyScherzinger added this to the Nc Android lib 2.23.0 milestone Oct 29, 2025
@tobiasKaminsky
Copy link
Member

/backport to stable-2.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants