Skip to content

Add Attributes to Share #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobiasKaminsky merged 15 commits into from
Jun 10, 2025

Update library/src/androidTest/java/com/owncloud/android/lib/resource…

d922fac
Select commit
Loading
Failed to load commit list.
Merged

Add Attributes to Share #1706

Update library/src/androidTest/java/com/owncloud/android/lib/resource…
d922fac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 6, 2025 in 0s

43.06% (+0.05%) compared to e3edf7a

View this Pull Request on Codecov

43.06% (+0.05%) compared to e3edf7a

Details

Codecov Report

Attention: Patch coverage is 54.34783% with 21 lines in your changes missing coverage. Please review.

Project coverage is 43.06%. Comparing base (e3edf7a) to head (d922fac).

Files with missing lines Patch % Lines
...a/com/nextcloud/extensions/JsonObjectExtensions.kt 37.50% 3 Missing and 2 partials ⚠️
...b/resources/shares/UpdateShareRemoteOperation.java 0.00% 3 Missing and 1 partial ⚠️
...s/shares/attributes/ShareAttributesDeserializer.kt 33.33% 0 Missing and 4 partials ⚠️
...es/shares/attributes/ShareAttributesJsonHandler.kt 60.00% 2 Missing and 2 partials ⚠️
...m/owncloud/android/lib/resources/shares/OCShare.kt 50.00% 2 Missing ⚠️
...b/resources/shares/CreateShareRemoteOperation.java 83.33% 1 Missing ⚠️
...lib/resources/shares/attributes/ShareAttributes.kt 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1706      +/-   ##
============================================
+ Coverage     43.01%   43.06%   +0.05%     
- Complexity      979      988       +9     
============================================
  Files           231      235       +4     
  Lines          8525     8568      +43     
  Branches       1115     1123       +8     
============================================
+ Hits           3667     3690      +23     
- Misses         4353     4364      +11     
- Partials        505      514       +9
Files with missing lines Coverage Δ
...d/android/lib/resources/shares/ShareXMLParser.java 91.79% <100.00%> (+0.08%) ⬆️
...b/resources/shares/CreateShareRemoteOperation.java 81.03% <83.33%> (+1.03%) ⬆️
...lib/resources/shares/attributes/ShareAttributes.kt 83.33% <83.33%> (ø)
...m/owncloud/android/lib/resources/shares/OCShare.kt 42.10% <50.00%> (+0.24%) ⬆️
...b/resources/shares/UpdateShareRemoteOperation.java 57.33% <0.00%> (-3.24%) ⬇️
...s/shares/attributes/ShareAttributesDeserializer.kt 33.33% <33.33%> (ø)
...es/shares/attributes/ShareAttributesJsonHandler.kt 60.00% <60.00%> (ø)
...a/com/nextcloud/extensions/JsonObjectExtensions.kt 37.50% <37.50%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov