Skip to content

Add Attributes to Share #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasKaminsky merged 15 commits into from
Jun 10, 2025
Merged

Add Attributes to Share #1706

tobiasKaminsky merged 15 commits into from
Jun 10, 2025

Conversation

@alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented Apr 10, 2025 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 force-pushed the add-attributes-to-oc-share branch from bfca7dd to a07602d Compare May 5, 2025 11:01
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

This was referenced May 5, 2025
Merged
Closed
@tobiasKaminsky

This comment was marked as resolved.

Sign in to view
@alperozturk96

This comment was marked as resolved.

Sign in to view
@alperozturk96 alperozturk96 force-pushed the add-attributes-to-oc-share branch from 283f9ce to 59c0829 Compare May 6, 2025 09:47
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@tobiasKaminsky

This comment was marked as resolved.

Sign in to view
@alperozturk96 alperozturk96 force-pushed the add-attributes-to-oc-share branch from b82ae57 to 1c1a335 Compare May 8, 2025 09:57
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96
Copy link
Contributor Author

alperozturk96 commented May 8, 2025

@tobiasKaminsky Done, thank you for the fix.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 force-pushed the add-attributes-to-oc-share branch from 3ff8fea to efceb97 Compare May 26, 2025 04:27
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@codecov
Copy link

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.34783% with 21 lines in your changes missing coverage. Please review.

Project coverage is 43.06%. Comparing base (e3edf7a) to head (d922fac).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
...a/com/nextcloud/extensions/JsonObjectExtensions.kt 37.50% 3 Missing and 2 partials ⚠️
...b/resources/shares/UpdateShareRemoteOperation.java 0.00% 3 Missing and 1 partial ⚠️
...s/shares/attributes/ShareAttributesDeserializer.kt 33.33% 0 Missing and 4 partials ⚠️
...es/shares/attributes/ShareAttributesJsonHandler.kt 60.00% 2 Missing and 2 partials ⚠️
...m/owncloud/android/lib/resources/shares/OCShare.kt 50.00% 2 Missing ⚠️
...b/resources/shares/CreateShareRemoteOperation.java 83.33% 1 Missing ⚠️
...lib/resources/shares/attributes/ShareAttributes.kt 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1706      +/-   ##
============================================
+ Coverage     43.01%   43.06%   +0.05%     
- Complexity      979      988       +9     
============================================
  Files           231      235       +4     
  Lines          8525     8568      +43     
  Branches       1115     1123       +8     
============================================
+ Hits           3667     3690      +23     
- Misses         4353     4364      +11     
- Partials        505      514       +9
Files with missing lines Coverage Δ
...d/android/lib/resources/shares/ShareXMLParser.java 91.79% <100.00%> (+0.08%) ⬆️
...b/resources/shares/CreateShareRemoteOperation.java 81.03% <83.33%> (+1.03%) ⬆️
...lib/resources/shares/attributes/ShareAttributes.kt 83.33% <83.33%> (ø)
...m/owncloud/android/lib/resources/shares/OCShare.kt 42.10% <50.00%> (+0.24%) ⬆️
...b/resources/shares/UpdateShareRemoteOperation.java 57.33% <0.00%> (-3.24%) ⬇️
...s/shares/attributes/ShareAttributesDeserializer.kt 33.33% <33.33%> (ø)
...es/shares/attributes/ShareAttributesJsonHandler.kt 60.00% <60.00%> (ø)
...a/com/nextcloud/extensions/JsonObjectExtensions.kt 37.50% <37.50%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alperozturk96 alperozturk96 requested a review from ZetaTom May 26, 2025 04:54
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 requested a review from ZetaTom June 5, 2025 09:12
ZetaTom
ZetaTom reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general everything seems to work. One minor thing is that we're not actually checking that the attributes have been set correctly in any test case.

@alperozturk96
add attributes
3399d99 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add attributes
9826f68 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96 and others added 13 commits June 6, 2025 18:57
@alperozturk96
fix code analytics
1fd0c18 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
update file operations
af3d5d7 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
update doc
db03049 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
update doc
d5fcb1c 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
remove unnecessary logic
c1b9257 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
clear doc
06ae6af 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix potential crashes
a2fe11e 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix code analytics
5981cc5 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix SPDX license
48f16c7 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add attributes test
cefe9bf 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix code analytics
8918f9b 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
catch asBoolean
aa578fc 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 @ZetaTom
Update library/src/androidTest/java/com/owncloud/android/lib/resource…
d922fac 
…s/shares/CreateShareRemoteOperationIT.kt

Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
@alperozturk96 alperozturk96 force-pushed the add-attributes-to-oc-share branch from f970676 to d922fac Compare June 6, 2025 10:57
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

SpotBugs

CategoryBaseNew
Bad practice3534
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161160

@tobiasKaminsky tobiasKaminsky merged commit 20b4703 into master Jun 10, 2025
19 checks passed
@tobiasKaminsky tobiasKaminsky deleted the add-attributes-to-oc-share branch June 10, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZetaTom ZetaTom ZetaTom left review comments

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alperozturk96 @tobiasKaminsky @ZetaTom