Skip to content

Conversation

@surinder-tsys
Copy link
Collaborator

Localization added for RemoteOperationResult logMessage.

Wherever the logMessage is getting used to show snackbar or toast messages we have use getLogMessage(Context) to show localized messages.

@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.

Project coverage is 22.75%. Comparing base (fe2c9ff) to head (8309d0b).
Report is 60 commits behind head on master.

Files with missing lines Patch % Lines
...d/lib/common/operations/RemoteOperationResult.java 0.00% 57 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1619      +/-   ##
============================================
- Coverage     22.89%   22.75%   -0.14%     
- Complexity      617      618       +1     
============================================
  Files           215      215              
  Lines          8177     8234      +57     
  Branches       1040     1068      +28     
============================================
+ Hits           1872     1874       +2     
- Misses         6124     6180      +56     
+ Partials        181      180       -1     
Files with missing lines Coverage Δ
...d/lib/common/operations/RemoteOperationResult.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: A117870935 <surinder.kumar@t-systems.com>
@tobiasKaminsky tobiasKaminsky force-pushed the nmc/remote-result-translations branch from 4e706c0 to 8309d0b Compare January 14, 2025 12:07
@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@tobiasKaminsky tobiasKaminsky merged commit 630e9cf into master Jan 14, 2025
17 of 20 checks passed
@tobiasKaminsky tobiasKaminsky deleted the nmc/remote-result-translations branch January 14, 2025 13:56
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants