Skip to content

Conversation

@surinder-tsys
Copy link
Collaborator

@surinder-tsys surinder-tsys commented Jan 30, 2025

Use localized log message from library for Snackbar, Toast or any other UI places.

  • Tests written, or not not needed

Signed-off-by: A117870935 <surinder.kumar@t-systems.com>
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14475.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.31.0 milestone Jan 30, 2025
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5555
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5757
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5351
Security1818
Total503501

@alperozturk96
Copy link
Collaborator

/backport to stable-3.31

@tobiasKaminsky tobiasKaminsky merged commit 108c04e into master Feb 10, 2025
20 of 23 checks passed
@tobiasKaminsky tobiasKaminsky deleted the nmc/useLocalizedLogMessage branch February 10, 2025 09:52
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants