refactor: Prepare for Postgres 18#42
Conversation
|
Warning Rate limit exceeded@cbaker6 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 24 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughHeroes! The release workflows now target branch 18-3.6 and set LATEST accordingly. Docker images are bumped from PostgreSQL 17-bullseye to 18-trixie, and PostGIS is updated to 3.6.0. No new logic or public APIs were introduced. PLUS ULTRA! Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 6
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/release-pgpool.yml(1 hunks).github/workflows/release.yml(1 hunks)Dockerfile(1 hunks)Dockerfile.pgpool(1 hunks)
🧰 Additional context used
🪛 Checkov (3.2.334)
Dockerfile
[low] 1-51: Ensure that HEALTHCHECK instructions have been added to container images
(CKV_DOCKER_2)
Dockerfile.pgpool
[low] 1-57: Ensure that HEALTHCHECK instructions have been added to container images
(CKV_DOCKER_2)
🪛 YAMLlint (1.37.1)
.github/workflows/release-pgpool.yml
[error] 7-7: too many spaces inside brackets
(brackets)
[error] 7-7: too many spaces inside brackets
(brackets)
.github/workflows/release.yml
[error] 7-7: too many spaces inside brackets
(brackets)
[error] 7-7: too many spaces inside brackets
(brackets)
| - cron: '19 3 * * *' | ||
| push: | ||
| branches: [ main, 15-3.3, 17-3.5 ] | ||
| branches: [ main, 15-3.3, 18-3.6 ] |
There was a problem hiding this comment.
Discipline the brackets, future Symbol of Peace!
Remove the inner padding so the array reads [main, 15-3.3, 18-3.6]. Without it, lint will pounce and the workflow falters. PLUS ULTRA!
Apply this shining diff:
- branches: [ main, 15-3.3, 18-3.6 ]
+ branches: [main, 15-3.3, 18-3.6]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| branches: [ main, 15-3.3, 18-3.6 ] | |
| branches: [main, 15-3.3, 18-3.6] |
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 7-7: too many spaces inside brackets
(brackets)
[error] 7-7: too many spaces inside brackets
(brackets)
🤖 Prompt for AI Agents
In .github/workflows/release-pgpool.yml around line 7, the branches array has
extra inner padding; remove the spaces inside the brackets so the entry reads
exactly [main, 15-3.3, 18-3.6]. Edit the line to eliminate the inner spaces and
ensure the YAML linter accepts the array syntax.
|
|
||
| env: | ||
| LATEST: '17-3.5' | ||
| LATEST: '18-3.6' |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Keep the LATEST env val spotless!
Maintain consistent formatting mojo here as well to silence lint and keep automation roaring. PLUS ULTRA!
🤖 Prompt for AI Agents
In .github/workflows/release-pgpool.yml around line 10, the LATEST env value
"LATEST: '18-3.6'" needs to match the repository's YAML formatting conventions;
remove any extraneous whitespace, use the same quote style as other env entries,
and align indentation with surrounding keys so the line is spotless (e.g., no
trailing spaces, correct single-quote usage, and consistent key/value spacing).
| - cron: '19 3 * * *' | ||
| push: | ||
| branches: [ main, 15-3.3, 17-3.5 ] | ||
| branches: [ main, 15-3.3, 18-3.6 ] |
There was a problem hiding this comment.
Tighten the bracket spacing, young hero!
YAML lint cries out because of the padding around the brackets. Trim it to [main, 15-3.3, 18-3.6] so the workflow stays triumphant! PLUS ULTRA!
Apply this victory diff:
- branches: [ main, 15-3.3, 18-3.6 ]
+ branches: [main, 15-3.3, 18-3.6]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| branches: [ main, 15-3.3, 18-3.6 ] | |
| branches: [main, 15-3.3, 18-3.6] |
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 7-7: too many spaces inside brackets
(brackets)
[error] 7-7: too many spaces inside brackets
(brackets)
🤖 Prompt for AI Agents
.github/workflows/release.yml around line 7: the branch list currently has extra
spaces inside the square brackets which fails YAML linting; remove the padding
so the line reads with no spaces inside the brackets (i.e. change "branches: [
main, 15-3.3, 18-3.6 ]" to use compact bracket spacing "[main, 15-3.3, 18-3.6]")
and save the file.
|
|
||
| env: | ||
| LATEST: '17-3.5' | ||
| LATEST: '18-3.6' |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Set env.LATEST with heroic precision!
Match the no-padding style here too so lint and builds keep smiling: LATEST: '18-3.6' is fine, just ensure no stray bracket padding. PLUS ULTRA!
🤖 Prompt for AI Agents
.github/workflows/release.yml around line 10: the LATEST environment value has
stray padding/brackets; remove any surrounding bracket padding so the line reads
exactly LATEST: '18-3.6' with no extra spaces or brackets, ensuring lint passes
and the workflow matches the no-padding style used elsewhere.
No description provided.