refactor: Update to latest postgis#43
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbit
WalkthroughUpdated PostGIS metadata and POSTGIS_VERSION environment variable in two Dockerfiles: Changes
Sequence Diagram(s)No sequence diagrams provided — changes are metadata/version string updates only (no control-flow or behavioral changes). Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
Dockerfile(1 hunks)Dockerfile.pgpool(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: docker
- GitHub Check: docker
🔇 Additional comments (1)
Dockerfile (1)
4-4: Description updated correctly—smashing!Label matches intended PostGIS bump for trixie. Plus Ultra!
|
|
||
| ENV POSTGIS_MAJOR=3 | ||
| ENV POSTGIS_VERSION=3.6.0+dfsg-1.pgdg13+1 | ||
| ENV POSTGIS_VERSION=3.6.0+dfsg-2.pgdg13+1 |
There was a problem hiding this comment.
🧩 Analysis chain
Version bump looks right—confirm availability.
Ensure apt.postgresql.org for trixie has postgresql-18-postgis-3 at 3.6.0+dfsg-2.pgdg13+1 to keep builds green.
🌐 Web query:
Does apt.postgresql.org provide package "postgresql-18-postgis-3" with version "3.6.0+dfsg-2.pgdg13+1" for Debian trixie (Debian 13)?
💡 Result:
No. apt.postgresql.org (the PGDG pool) provides postgresql-18-postgis-3 for trixie as 3.6.0+dfsg-1.pgdg13+1 (see the PGDG pool listing). The 3.6.0+dfsg-2 build appears in Debian/unpacked suites (sid/forky) per packages.debian.org, not as 3.6.0+dfsg-2.pgdg13+1 on apt.postgresql.org for trixie. [1][2]
Sources:
- apt.postgresql.org pool listing showing postgresql-18-postgis-3_3.6.0+dfsg-1.pgdg13+1. [1]
- Debian package search / packages.debian.org showing 3.6.0+dfsg-2 in unstable/testing (not PGDG trixie). [2]
Specify available PostGIS version for Debian trixie
apt.postgresql.org pool for trixie only provides postgresql-18-postgis-3 at 3.6.0+dfsg-1.pgdg13+1, not 3.6.0+dfsg-2.pgdg13+1—adjust ENV POSTGIS_VERSION to 3.6.0+dfsg-1.pgdg13+1 to keep builds green! Plus Ultra!
🤖 Prompt for AI Agents
In Dockerfile around line 8, ENV POSTGIS_VERSION is set to 3.6.0+dfsg-2.pgdg13+1
which is not available in the Debian trixie apt.postgresql.org pool; update the
value to the available package version 3.6.0+dfsg-1.pgdg13+1 to match the
repository and ensure builds succeed, then rebuild/test the image to verify the
package resolves.
|
|
||
| LABEL maintainer="HIPAA Postgres w/ PostGIS Project" \ | ||
| org.opencontainers.image.description="PostGIS 3.5.2+dfsg-1.pgdg110+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \ | ||
| org.opencontainers.image.description="PostGIS 3.5.2+dfsg-2.pgdg110+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \ |
There was a problem hiding this comment.
Metadata mismatch: label shows 3.5.2/pgdg110, env uses 3.6.0/pgdg13. Fix to stay heroic.
Align the description with the actual version/distro to avoid confusion.
Apply this diff:
- org.opencontainers.image.description="PostGIS 3.5.2+dfsg-2.pgdg110+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \
+ org.opencontainers.image.description="PostGIS 3.6.0+dfsg-2.pgdg13+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| org.opencontainers.image.description="PostGIS 3.5.2+dfsg-2.pgdg110+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \ | |
| org.opencontainers.image.description="PostGIS 3.6.0+dfsg-2.pgdg13+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \ |
🤖 Prompt for AI Agents
In Dockerfile.pgpool around line 4, the org.opencontainers.image.description
label states PostGIS 3.5.2/pgdg110 while the image/environment uses PostGIS
3.6.0/pgdg13; update the description label to accurately reflect the actual
PostGIS version and distro (e.g., "PostGIS 3.6.0+dfsg-... pgdg13") so metadata
matches the image (alternatively, if the intended target is 3.5.2/pgdg110,
change the environment/version to match the label), ensuring the label text
exactly matches the real version and package identifier.
|
|
||
| ENV POSTGIS_MAJOR=3 | ||
| ENV POSTGIS_VERSION=3.6.0+dfsg-1.pgdg13+1 | ||
| ENV POSTGIS_VERSION=3.6.0+dfsg-2.pgdg13+1 |
There was a problem hiding this comment.
🧩 Analysis chain
POSTGIS_VERSION bump looks solid—let’s verify the package exists.
Confirm the package/version is published for trixie to ensure reproducible builds.
🌐 Web query:
Confirm availability of "postgresql-18-postgis-3" version "3.6.0+dfsg-2.pgdg13+1" in the PGDG trixie repository.
💡 Result:
I could not find evidence that the exact package version "3.6.0+dfsg-2.pgdg13+1" exists in the PGDG trixie repository. PGDG/apt listings show trixie packages with version "3.6.0+dfsg-1.pgdg13+1" for postgresql-18-postgis-3. [1] The Debian tracker shows postgis 3.6.0+dfsg-2 was accepted into Debian unstable (source) but without the "pgdg13+1" PGDG build suffix. [2]
Sources:
- PGDG package listing showing trixie entry as 3.6.0+dfsg-1.pgdg13+1. [1]
- Debian tracker / news entry for postgis 3.6.0+dfsg-2 (accepted into unstable). [2]
Update Dockerfile.pgpool ENV POSTGIS_VERSION to 3.6.0+dfsg-1.pgdg13+1
The PGDG trixie repo only provides that version—3.6.0+dfsg-2.pgdg13+1 will not be found. Plus Ultra!
🤖 Prompt for AI Agents
In Dockerfile.pgpool around line 8, the POSTGIS_VERSION ENV is set to
3.6.0+dfsg-2.pgdg13+1 which does not exist in the PGDG trixie repo; change the
value to 3.6.0+dfsg-1.pgdg13+1 so the package can be resolved and builds succeed
— update the ENV line accordingly and run a quick build to verify the image
pulls the correct PostGIS package.
1 participant
No description provided.