Skip to content

Conversation

@yarikoptic
Copy link
Contributor

@yarikoptic yarikoptic commented Feb 19, 2025

  • Duplication is evil
  • I do not see a reason to not support specific per OS versions of Python but if needed, could always be done via "exclude"
  • requirements.txt file seems to be always there so unclear why to check
  • If works on Mac, Closes macos support? #30

In my initial attempts which ran CI on my fork it seems that the single immediate mac failure just (run log: https://github.com/yarikoptic/command_runner/actions/runs/13413365712/job/37468918740)

FAILED tests/test_command_runner.py::test_valid_exit_codes - AssertionError: Exit code not in valid list with method monitor
assert 68 in [0, 1, 2]

but it is what it is:

yoh@datalads-imac2 ~ % ping lkajsdf.com
ping: cannot resolve lkajsdf.com: Unknown host
yoh@datalads-imac2 ~ % echo $?
68

so just adding the fix for that . Current tests run is at https://github.com/yarikoptic/command_runner/actions/runs/13413780728

TODOs:

  • change to true the cancel-in-progress: whenever all is good
  • drop any python before 3.8 (pypy included) -- not supported etc

…o the matrix of OSes

- Duplication is evil
- I do not see a reason to not support specific per OS versions of Python
  but if needed, could always be done via "exclude"
- requirements.txt file seems to be always there so unclear why to check
- If works on Mac, Closes netinvent#30
want to troubleshoot what is not good with jobs first
@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.09%. Comparing base (7061909) to head (ee406d8).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
tests/test_command_runner.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   76.00%   76.09%   +0.08%     
==========================================
  Files           2        2              
  Lines        1017     1029      +12     
==========================================
+ Hits          773      783      +10     
- Misses        244      246       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deajan
Copy link
Contributor

deajan commented Feb 19, 2025

Duplication is evil

So there's a reason I don't want to unify the test workflows.
Windows tests take way longer than linux ones (because of polling tests).
Sometimes I even get thrown back from github because of too much execution time.

So yes, I will keep duplication

requirements.txt file seems to be always there so unclear why to check

Indeed, this comes from another workflow which I use for generic projects (I avoid duplication when I can).
Can be deleted here, but will make me more work later.

[...] mac exit code 68

Thanks for having tested this. Fix looks good to me.

Drop python before 3.8

Also, please don't drop older Python versions from test matrix, I support them as long as github provides them.
This project is used in some corner cases where people are stuck with python versions on embedded hardware, so it's reasonable to have tests for the oldest possible python version

Overall, thank you for the effort you put into this.

@yarikoptic yarikoptic mentioned this pull request Feb 19, 2025
@yarikoptic
Copy link
Contributor Author

you are most welcome!
ok, I guess let's just close this PR. please reopen / guide if I misunderstood and you would like it finished one way or another

@yarikoptic yarikoptic closed this Feb 19, 2025
@deajan
Copy link
Contributor

deajan commented Feb 19, 2025

Sure, I'd actually love to see the macos fix in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macos support?

2 participants