Skip to content

add option to mujin_webstackclientpy_downloaddata.py#73

Closed
kanbouchou wants to merge 2 commits into
masterfrom
file_extension_to_mujin_webstackclientpy_downloaddata
Closed

add option to mujin_webstackclientpy_downloaddata.py#73
kanbouchou wants to merge 2 commits into
masterfrom
file_extension_to_mujin_webstackclientpy_downloaddata

Conversation

@kanbouchou
Copy link
Copy Markdown
Contributor

@kanbouchou kanbouchou commented Sep 11, 2025

Description

  • This MR adds option for user to specify scene file extension (such as json).

Test

  • Manually verified that downloaded scene format can be controlled by sceneExtension
  • test pipeline 1505777

@kanbouchou kanbouchou requested a review from woswos September 24, 2025 08:41
@kanbouchou kanbouchou changed the title Draft: add option to mujin_webstackclientpy_downloaddata.py add option to mujin_webstackclientpy_downloaddata.py Sep 24, 2025
@woswos
Copy link
Copy Markdown
Member

woswos commented Sep 25, 2025

Hi @kanbouchou, I actually worked on this feature before here https://github.com/mujin/mujinwebstackclientpy/pull/54/files

Webstack already allows specifying the format without additional URI manipulation. Can we use the other PR unless there is a reason to do the URI manipulation in this PR?

@kanbouchou
Copy link
Copy Markdown
Contributor Author

Hi @kanbouchou, I actually worked on this feature before here https://github.com/mujin/mujinwebstackclientpy/pull/54/files

Webstack already allows specifying the format without additional URI manipulation. Can we use the other PR unless there is a reason to do the URI manipulation in this PR?

@woswos got it.

superseded by https://github.com/mujin/mujinwebstackclientpy/pull/54/files. closing.

@kanbouchou kanbouchou closed this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants