osc.lua: add observe_cached() helper#17563
Open
guidocella wants to merge 1 commit intompv-player:masterfrom
Open
osc.lua: add observe_cached() helper#17563guidocella wants to merge 1 commit intompv-player:masterfrom
guidocella wants to merge 1 commit intompv-player:masterfrom
Conversation
Samillion
reviewed
Mar 22, 2026
Comment on lines
+316
to
+321
| local function observe_cached(property, callback) | ||
| mp.observe_property(property, "native", function (_, value) | ||
| state[property:gsub("-", "_")] = value | ||
| callback() | ||
| end) | ||
| end |
Contributor
There was a problem hiding this comment.
Suggested change
| local function observe_cached(property, callback) | |
| mp.observe_property(property, "native", function (_, value) | |
| state[property:gsub("-", "_")] = value | |
| callback() | |
| end) | |
| end | |
| local function observe_cached(property, callback) | |
| local key = property:gsub("-", "_") | |
| mp.observe_property(property, "native", function (_, value) | |
| state[key] = value | |
| callback() | |
| end) | |
| end |
This is probably trivial to suggest, but wouldn't it better to use gsub outside the observer? To avoid excess calls.
Contributor
Author
There was a problem hiding this comment.
Sure we can micro-optimize it.
This removes code repetition and will make caching more properties easier. Some state fields are renamed to have the same name as the property.
Contributor
|
I've been running this for a while now, works really well. Are you planning to do the same for:
|
Contributor
Author
|
Yeah I'll cache everything that is useful after this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes code repetition and will make caching more properties easier.
Some state fields are renamed to have the same name as the property.