Skip to content

Fix remaining mixed-decls warnings (Fix #998) #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephaniehobson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix remaining mixed-decls warnings (Fix #998) #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions assets/sass/protocol/base/elements/_forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ label {
@include forms.field-label;

&.mzp-u-inline {
@include bidi(((padding, 0 $spacing-sm 0 0, 0 0 0 $spacing-sm),));
display: inline;
@include bidi(((padding, 0 $spacing-sm 0 0, 0 0 0 $spacing-sm),));
}
}

Expand Down Expand Up @@ -301,11 +301,6 @@ input[type='file'] {
select {
appearance: none;
box-sizing: border-box;
@include bidi((
(background-position, right 8px top 50%, left 8px top 50%),
(padding, forms.$field-padding forms.$symbol-spacing forms.$field-padding forms.$field-padding, forms.$field-padding forms.$field-padding forms.$field-padding forms.$symbol-spacing),
));
@include forms.form-input;
background-image: $url-image-caret-down-form, forms.$select-bg;
background-repeat: no-repeat, repeat;
background-size: 1em auto, 100%;
Expand All @@ -314,6 +309,11 @@ select {
max-width: 100%;
min-width: forms.$field-min-width;
text-overflow: ellipsis;
@include forms.form-input;
@include bidi((
(background-position, right 8px top 50%, left 8px top 50%),
(padding, forms.$field-padding forms.$symbol-spacing forms.$field-padding forms.$field-padding, forms.$field-padding forms.$field-padding forms.$field-padding forms.$symbol-spacing),
));

// no down arrow on multi selects
&[multiple] {
Expand Down
16 changes: 8 additions & 8 deletions assets/sass/protocol/base/elements/_lists.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,44 +13,44 @@ ol {
}

ul.mzp-u-list-styled {
@include bidi(((margin-left, $layout-sm, margin-right, 0),));
list-style: disc;
@include bidi(((margin-left, $layout-sm, margin-right, 0),));

li {
margin-bottom: 0.25em;
}

ul {
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
list-style: circle;
margin-bottom: 0;
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
}

ol {
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
list-style: decimal;
margin-bottom: 0;
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
}
}

ol.mzp-u-list-styled {
@include bidi(((margin-left, $layout-sm, margin-right, 0),));
list-style: decimal;
@include bidi(((margin-left, $layout-sm, margin-right, 0),));

li {
margin-bottom: 0.25em;
}

ol {
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
list-style: lower-alpha;
margin-bottom: 0;
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
}

ul {
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
list-style: disc;
margin-bottom: 0;
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
}
}

Expand All @@ -61,14 +61,14 @@ dl.mzp-u-list-styled {
}

dd {
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
margin-bottom: 0.25em;
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
}

ul,
ol {
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
margin-bottom: 0;
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
}

ul {
Expand Down
2 changes: 1 addition & 1 deletion assets/sass/protocol/base/elements/_quotes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
@use '../../includes/lib' as *;

blockquote {
@include bidi(((border-width, 0 0 0 5px, 0 5px 0 0),));
@include text-heading-sm;
border-color: $color-marketing-gray-20;
border-style: solid;
color: var(--theme-heading-text-color);
font-weight: bold;
margin: $spacing-lg auto;
padding: $spacing-sm $spacing-lg;
@include bidi(((border-width, 0 0 0 5px, 0 5px 0 0),));

cite {
@include text-heading-xs;
Expand Down
4 changes: 2 additions & 2 deletions assets/sass/protocol/base/elements/_tables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@
border-spacing: 0;

caption {
@include bidi(((text-align, left, right),));
margin-bottom: 0.25em;
width: 100%;
text-align: start;
}

th,
td {
@include bidi(((text-align, left, right),));
border-top: 1px solid rgb(0, 0, 0, 0.2);
padding: 0.5em 10px;
text-align: left;
text-align: start;
}

thead th,
Expand Down
6 changes: 3 additions & 3 deletions assets/sass/protocol/base/utilities/_rich-text.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,17 @@
}

ul {
@include bidi(((margin-left, $layout-sm, margin-right, 0),));
list-style-type: disc;
@include bidi(((margin-left, $layout-sm, margin-right, 0),));

ul {
list-style-type: circle;
}
}

ol {
@include bidi(((margin-left, $layout-sm, margin-right, 0),));
list-style-type: decimal;
@include bidi(((margin-left, $layout-sm, margin-right, 0),));

ol {
list-style-type: lower-roman;
Expand All @@ -85,8 +85,8 @@
}

dd {
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
margin-bottom: 0.25em;
@include bidi(((margin-left, $layout-xs, margin-right, 0),));
}

pre {
Expand Down
4 changes: 2 additions & 2 deletions assets/sass/protocol/components/_article.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
@media #{$mq-md} {
// Float left when sidebar is on the left
.mzp-l-sidebar-left .mzp-l-main & {
@include bidi(((float, left, right),));
float: inline-start;
}

// Float right when sidebar is on the right
.mzp-l-sidebar-right .mzp-l-main & {
@include bidi(((float, right, left),));
float: inline-end;
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion assets/sass/protocol/components/_breadcrumb.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@

+ .mzp-c-breadcrumb-item {
&::before {
@include bidi(((content, '\2192', '\2190'),));
font-weight: normal;
margin: 0 0.25em;
@include bidi(((content, '\2192', '\2190'),));
}
}

Expand Down
6 changes: 3 additions & 3 deletions assets/sass/protocol/components/_card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@

&.mzp-has-video .mzp-c-card-tag,
&.mzp-has-audio .mzp-c-card-tag {
background-repeat: no-repeat;
line-height: 1.8;
min-height: 25px;
@include bidi((
(background-position, center left, center right),
(padding-left, $spacing-xl, padding-right, 0),
));
background-repeat: no-repeat;
line-height: 1.8;
min-height: 25px;
}

&.mzp-has-video .mzp-c-card-tag {
Expand Down
24 changes: 12 additions & 12 deletions assets/sass/protocol/components/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@
// Footer section containing list and heading

.mzp-c-footer-sections {
@include clearfix;
@include footer-line;
padding-bottom: $layout-sm;
@include footer-line;
@include clearfix;

@media #{$mq-sm} {
padding-bottom: 0;
Expand All @@ -100,11 +100,11 @@
}

@media (min-width: #{$screen-sm}) and (max-width: #{$screen-lg - 1px}) {
@include bidi(((float, left, right),));
@include grid-half;
float: inline-start;

&:nth-child(odd) {
@include bidi(((clear, left, right),));
clear: inline-start;
@include bidi(((padding, 0 ($layout-md * 0.5) 0 0, 0 0 0 ($layout-md * 0.5)),));
}

Expand All @@ -116,8 +116,8 @@

@media #{$mq-lg} {
.mzp-c-footer-section {
@include bidi(((float, left, right),));
padding: 0 ($layout-md * 0.5);
float: inline-start;

&:first-child {
@include bidi(((padding, 0 ($layout-md * 0.5) 0 0, 0 0 0 ($layout-md * 0.5)),));
Expand Down Expand Up @@ -151,10 +151,10 @@
padding: $spacing-md 0;
position: relative;
width: 100%;
@include bidi(((text-align, left, right),));
@include footer-line;
@include text-body-md;
@include font-mozilla-text;
text-align: start;

/* stylelint-disable-next-line no-duplicate-selectors */
& {
Expand All @@ -178,14 +178,14 @@
button::before {
background: $url-image-expand-white top left no-repeat;
background-size: 24px, 24px;
@include bidi(((right, 8px, left, auto),));
transition: transform 100ms ease-in-out;
content: '';
height: 24px;
margin-top: -12px;
position: absolute;
top: 50%;
width: 24px;
@include bidi(((right, 8px, left, auto),));
}

button[aria-expanded='true']::before {
Expand Down Expand Up @@ -255,7 +255,7 @@
margin-bottom: $layout-sm;

@media #{$mq-md} {
@include bidi(((float, right, left),));
float: inline-end;
}
}

Expand All @@ -266,9 +266,9 @@
margin-bottom: $layout-sm;

li {
@include bidi(((margin, 0 $spacing-md 0 0, 0 0 0 $spacing-md),));
display: inline-block;
vertical-align: bottom;
@include bidi(((margin, 0 $spacing-md 0 0, 0 0 0 $spacing-md),));

a {
@include image-replaced;
Expand Down Expand Up @@ -298,12 +298,12 @@
}

@media #{$mq-md} {
@include bidi(((right, 0, left, auto),));
@include bidi(((text-align, right, left),));
bottom: 0;
margin-bottom: 0;
max-width: 33%; // don't over lap with legal links
position: absolute;
@include bidi(((right, 0, left, auto),));
text-align: end;

li {
@include bidi((
Expand All @@ -329,8 +329,8 @@

@media #{$mq-md} {
li {
@include bidi(((padding, 0 $spacing-lg 0 0, 0 0 0 $spacing-lg),));
display: inline-block;
@include bidi(((padding, 0 $spacing-lg 0 0, 0 0 0 $spacing-lg),));

&:last-child {
@include bidi(((padding-right, 0, padding-left, 0),));
Expand Down
2 changes: 1 addition & 1 deletion assets/sass/protocol/components/_language-switcher.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
label,
.mzp-c-language-switcher-link {
display: inline-block;
@include bidi(((margin, 0 $spacing-lg $spacing-sm 0, 0 0 $spacing-sm $spacing-lg),));
font-size: var(--theme-body-font-size-sm); // just want smaller text size, so don't use full mixin
@include bidi(((margin, 0 $spacing-lg $spacing-sm 0, 0 0 $spacing-sm $spacing-lg),));
}

// hide the <label> visually should a language link be shown instead.
Expand Down
6 changes: 3 additions & 3 deletions assets/sass/protocol/components/_menu-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,16 @@ $icon-size: 24px;
&.mzp-has-icon {
.mzp-c-menu-item-head,
.mzp-c-menu-item-link {
@include bidi(((padding-left, $icon-size + $spacing-lg, padding-right, 0),));
position: relative;
@include bidi(((padding-left, $icon-size + $spacing-lg, padding-right, 0),));

.mzp-c-menu-item-icon {
@include bidi(((left, $spacing-sm, right, auto),));
height: $icon-size;
margin: 0;
position: absolute;
top: $spacing-sm;
width: $icon-size;
@include bidi(((left, $spacing-sm, right, auto),));
}
}
}
Expand Down Expand Up @@ -91,8 +91,8 @@ $icon-size: 24px;

@media #{$mq-sm} {
li {
@include bidi(((float, left, right),));
width: calc(50% - #{$spacing-sm});
float: inline-start;

&:nth-child(odd) {
@include bidi((
Expand Down
Loading
Loading