Skip to content

Bug 1919317: Fix the tooltip for Total Runs column #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moijes12 wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −20
Open

Bug 1919317: Fix the tooltip for Total Runs column #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/components/CompareResults/RevisionRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,16 +395,18 @@ function RevisionRow(props: RevisionRowProps) {
)}
</div>
{renderDifferingTestVersionColumns(testVersion ?? STUDENT_T, result)}
<div className='total-runs cell' role='cell'>
<span>
<span title='Base runs'>B:</span>
<strong>{baseRunsCount}</strong>
</span>
<span>
<span title='New runs'>N:</span>
<strong>{newRunsCount}</strong>
</span>
</div>
<Tooltip title={`Base runs: ${baseRunsCount}, New runs: ${newRunsCount}`} placement="bottom">
<div className='total-runs cell' role='cell'>
<span>
<span title='Base runs'>B:</span>
<strong>{baseRunsCount}</strong>
</span>
<span>
<span title='New runs'>N:</span>
<strong>{newRunsCount}</strong>
</span>
</div>
</Tooltip>
<div className='row-buttons cell'>
{result.has_subtests && (
<div className='subtests' role='cell'>
Expand Down
23 changes: 13 additions & 10 deletions src/components/CompareResults/SubtestsResults/SubtestsRevisionRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import ThumbDownIcon from '@mui/icons-material/ThumbDown';
import ThumbUpIcon from '@mui/icons-material/ThumbUp';
import TimelineIcon from '@mui/icons-material/Timeline';
import { IconButton, Box } from '@mui/material';
import Tooltip from '@mui/material/Tooltip';
import { style } from 'typestyle';

import RevisionRowExpandable from '.././RevisionRowExpandable';
Expand Down Expand Up @@ -318,16 +319,18 @@ function SubtestsRevisionRow(props: RevisionRowProps) {
result,
expanded,
)}
<div className='total-runs cell' role='cell'>
<span>
<span title='Base runs'>B:</span>
<strong>{baseRunsCount}</strong>
</span>
<span>
<span title='New runs'>N:</span>
<strong>{newRunsCount}</strong>
</span>
</div>
<Tooltip title={`Base runs: ${baseRunsCount}, New runs: ${newRunsCount}`} placement="bottom">
<div className='total-runs cell' role='cell'>
<span>
<span title='Base runs'>B:</span>
<strong>{baseRunsCount}</strong>
</span>
<span>
<span title='New runs'>N:</span>
<strong>{newRunsCount}</strong>
</span>
</div>
</Tooltip>
<div className='row-buttons cell'>
<div className='graph' role='cell'>
<div className='graph-link-button-container'>
Expand Down