Bug 1919317: Fix the tooltip for Total Runs column #992
+25
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change wraps the Base runs and New Runs in a single combined Tooltip mui element. This provides a combined tooltip rather than having to use the title provided by the individual span elements. This update has been applied to the RevisionRow and SubtestsRevisionRow components.
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
Hey @moijes12 thanks so much for your very first contribution to PerfCompare! I'll defer to @kala-moz to provide a review for your changes. Are you able to provide before/after screenshots showing the improvement? I also notice that there are a few linting and test failures - are you able to run these locally and address them? |
Contributor
|
Hi @moijes12, Kala here. Thanks again for your contribution. Just wanted to reiterate what Dave said, please provide screenshots and make sure linting and tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change wraps the Base runs and New Runs in a single combined Tooltip mui element.
This provides a combined tooltip rather than having to use the title provided by the individual span elements.
This update has been applied to the RevisionRow and SubtestsRevisionRow components.
@davehunt This is my first contribution to Perfcompare so it might take more than one revision. This will improve going forward