Open
Conversation
jo
force-pushed
the
remove-breach-info
branch
from
716dd3f to
6a1f361
Compare
jo
force-pushed
the
remove-breach-info
branch
2 times, most recently
from
696c897 to
402c728
Compare
In mozilla#7127, we added breach alerts support. However, in further discussions, we came to the conclusion that the column `time_of_last_breach` is not directly necessary, as this information can also be pulled from the Remote Settings during runtime. Performance optimizations should be subordinate to the principle of data spareness. Therefore, this PR removes the `time_of_last_breach` column introduced in mozilla#7127. Since this column is not yet used in Mobile, no data migration is necessary.
jo
force-pushed
the
remove-breach-info
branch
from
402c728 to
080247f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7127, we added breach alerts support.
However, in further discussions, we came to the conclusion that the column
time_of_last_breachis not directly necessary, as this information can also be pulled from the Remote Settings during runtime. Performance optimizations should be subordinate to the principle of data spareness.Therefore, this PR removes the
time_of_last_breachcolumn introduced in #7127, along with their accessors. Since this column is not yet used in Mobile, no data migration is necessary.time_of_last_breachfield fromLoginMetaandLogin. This can be derived from Remote Settings during runtime instead.record_breach(id, timestamp)API method.is_potentially_breached(id)API method.is_breach_alert_dismissed(id)API method.reset_all_breaches()now clears thebreachesLpassword table instead of resettingtime_of_last_breachtimestamps.timeOfLastBreachcolumn dropped fromloginsLandloginsM.A Phab Patch will be created to adapt LoginsStorage.kt and Types.kt.
Pull Request checklist
[ci full]to the PR title.