Merged
Conversation
bendk
force-pushed
the
push-yookuwoloqzy
branch
from
c4812e2 to
d786e84
Compare
Run all tests together rather than one at a time with `--manifest-path` This allows cargo to cache dependencies better. In particular, this should result in less `uniffi_bindgen` builds. Don't run `cargo clean` between each step, the underlying clippy issue has been fixed. Had to add an extra clippy allow, since the new method of running clippy makes it get the 2024 edition lints.
bendk
force-pushed
the
push-yookuwoloqzy
branch
from
d786e84 to
d2d7162
Compare
Contributor
Author
|
Looks like this was a success.
|
bendk
commented
Feb 26, 2026
| - test-setup | ||
| - setup-rust-min-version | ||
| # tests.py doesn't support skipping tests, and we need to skip the systests on this rust version. | ||
| # It's not in the default workspace members, so just `cargo test` is OK. |
Contributor
Author
There was a problem hiding this comment.
AFAICT, this was just an old comment that doesn't make sense anymore. Tell me if I'm confused and there's still some value to it.
Contributor
Author
|
I could have documented things a bit better, but I don't think this will survive the monorepo move so it didn't seem worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
-prather than--manifest-path. This allows cargo to cache dependencies better. In particular, this should result in lessuniffi_bindgenbuilds.Pull Request checklist
[ci full]to the PR title.