fix(devtools-connect): go back to reading driver metadata field
#613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially adjusts the changes in 55e28dc -- we should get this data both when using the 7.x and 6.x driver. Because this field is private/async in the 7.x driver, this patch also adds integration tests for both versions.
addaleax
commented
Jan 22, 2026
| // TODO: Use a public API once NODE-7406 is done. | ||
| // `metadata` became internal + async in v7.x, previously it | ||
| // was synchronously available. | ||
| driver: (await (client.options as any).metadata).driver, |
Collaborator
Author
There was a problem hiding this comment.
For now you can stick with
client.options.metadatawhile we figure out the best way to solve it.
kmruiz
approved these changes
Jan 23, 2026
| "gen-esm-wrapper": "^1.1.3", | ||
| "mocha": "^8.4.0", | ||
| "mongodb": "^6.9.0 || ^7.0.0", | ||
| "mongodb": "^7.0.0", |
Collaborator
There was a problem hiding this comment.
Do we want to remove support for 6x already? I'm fine with it if it does not break backwards compatibility.
Collaborator
Author
There was a problem hiding this comment.
I'd also be fine with that, but I don't see any strong reason to do so until all of our products are on 7.x
(This PR does not remove support for 6.x, on the contrary, it adds explicit testing with both the 6.x and 7.x driver. This is the devDependencies list, not the dependencies list)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially adjusts the changes in 55e28dc -- we should get this data both when using the 7.x and 6.x driver. Because this field is private/async in the 7.x driver, this patch also adds integration tests for both versions.
Description
Open Questions
Checklist