feat(grid): add get_node() method to all grid types #2680
Merged
+242
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
get_node()method toVertexGridandUnstructuredGrid, consistent withStructuredGrid, for cell ID -> node number conversions. Rename thelrc_listparameter onStructuredGrid.get_node()tocellidsand deprecatelrc_list. Add an optionalnode2dparameter to determine whether to get the 2D or 3D node number, useful for structured and vertex grids, ignored for unstructured.The cell ID -> node number conversion was done ad hoc in a few places in the codebase, this allows some simplification. Maybe in 4.x we can standardize the signature and pull an abstract method into the base
Gridclass.