refactor(plot): better shared face finding for HFB plotting #2682
+507
−203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the shared face finding algorithm for HFB (Horizontal Flow Barrier) plotting. Factors out @jlarsen-usgs's index-based approach from #2671 into reusable functions. The index-based approach avoids floating point comparisons and will be faster than the previous approach. I also moved the new face-related functions to a new module
faceutil.pyinstead ofplotutil.pyso #2671 can reuse them for export, and in case they are generally useful. I considered putting them ingridutil.pybut that is used by the grid classes, while the face functions use the grid classes, so it would have created a circular import.This PR takes advantage of
get_node()methodihcinit parameter/attribute toUnstructuredGrid