-
Notifications
You must be signed in to change notification settings - Fork 17
Add Met Office Global Deterministic height level dataset #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks @mo-jeff! Some thoughts:
Let us handle the |
|
@ghidalgo3 - updated this PR. To your comments:
@gadomski - most of the technical detail is here now I think. Descriptions to follow soon. |
@microsoft-github-policy-service agree company="Met Office" |
gadomski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it a quick once-over, no major issues. We'll want to populate the item_assets with more information once that's prepared ... I'm working on that now.
datasets/met-office/collection/met-office-global-deterministic-height-level/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-global-deterministic-height-level/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-uk-deterministic-height/template.json
Outdated
Show resolved
Hide resolved
| "title": "Creative Commons Attribution-ShareAlike 4.0" | ||
| }, | ||
| { | ||
| "rel": "cite-as", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a href for this link.
datasets/met-office/collection/met-office-uk-deterministic-pressure-level/template.json
Outdated
Show resolved
Hide resolved
…-height-level/template.json Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
…ght-level/template.json Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
datasets/met-office/collection/met-office-global-deterministic-height-level/template.json
Outdated
Show resolved
Hide resolved
datasets/met-office/collection/met-office-uk-deterministic-near-surface-level/template.json
Outdated
Show resolved
Hide resolved
| "type": "application/netcdf", | ||
| "title": "Fog fraction at screen level", | ||
| "description": "Here fog means a visibility of 1000 m or lower. The reduction in visibility is caused by water droplets or minute ice crystals forming close to the surface. This quantity represents the fraction of horizontal grid square occupied by fog. An alternative interpretation is that this represents the fractional probability of fog being present at any location in the grid square.", | ||
| "unit": "1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "unit": "1", | |
| "unit": "%", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the info for these params came from the science team/content team so I've copied and pasted it into here. This one is a fraction, so the values are percentages I don't think, the aim is to match with other documentation across all our public platforms, so I'll have to check this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rodger. The STAC spec strongly recommends using either UCUM or UDUNITS-2 for the unit field. If we do need to preserve the original value, I'd suggest putting the 1 into a custom met_office_determinstic:unit field, and using a more commonly-used value % for the bare unit field.
Sorry, how is the fraction represented? As a float?
| "title": "Fog fraction at screen level", | ||
| "description": "Here fog means a visibility of 1000 m or lower. The reduction in visibility is caused by water droplets or minute ice crystals forming close to the surface. This quantity represents the fraction of horizontal grid square occupied by fog. An alternative interpretation is that this represents the fractional probability of fog being present at any location in the grid square.", | ||
| "unit": "1", | ||
| "height": "1.5m", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite sure about this one...if it's a dataset-specific value, we may want to use a custom "extension" attribute, e.g. met_office_deterministic:height. There's also other values that reference "at screen level" but don't have a height, so maybe this should just be excluded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've queried this too, it may be better in the description.md markdown, a catch-all statement "Screen level at 1.5m height" (or something), it also duplicates what we've got in the description key here, so that may be simplified as well
| "type": "application/netcdf", | ||
| "title": "Land binary mask", | ||
| "description": "Binary indicator of whether a point is considered land (value = 1) or sea (value = 0). This is useful to identify the coastline and characterise points for correct interpretation of forecast data by users.", | ||
| "unit": "1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could just be omitted, as its unitless.
| "unit": "1", |
datasets/met-office/collection/met-office-uk-deterministic-near-surface-level/template.json
Outdated
Show resolved
Hide resolved
…r-surface-level/template.json Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
…r-surface-level/template.json Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
…etary-computer-tasks into met-office-datasets
|
|
||
| ## Providers | ||
| [Met Office](https://www.metoffice.gov.uk/) | ||
| See all datasets managed by [Met Office.](https://registry.opendata.aws/?search=managedBy:met%20office) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming the ASDI link is a placeholder; Is there an equivalent to this for MPC?
If not, do we link to our website or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess would be a link to the "group", which is a Planetary Computer specific concept of a "group of collections". E.g. https://planetarycomputer.microsoft.com/dataset/group/landsat.
...sets/met-office/collection/met-office-uk-deterministic-whole-atmosphere-level/description.md
Outdated
Show resolved
Hide resolved
…al collection documentation
datasets/met-office/collection/met-office-global-deterministic-height-level/template.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with the datacube extension, we'll still want item assets. Those are used both on the database side (hydration) and are a useful indicator of what assets might be available for each collection.
EDIT: I'm also not sure about the cube extension living at the item level. A more common pattern would be to put the cube extension on each item_asset.
gadomski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not convinced on the value or correctness of putting 1H_timesteps in cube:dimensions. Any reason not to just keep it in the text descriptions?
I thought Temporal Dimensions might help us with this but maybe not. Happy to keep the Timestep header and content in the collection description and call out in the description for any parameters that don't follow that pattern? For example, there is a precip accumulation that is hourly from T+0 - T+51 (rather than T+54) |
Yeah, the datacube extension is intended to describe a single file. Since your forecast horizons are split into their own standalone files, it's not a good fit for the forecast horizons IMO. Still a good fit for the other dimensions. I think a good text description will be super-helpful for users, so 👍🏼 |
|
@mo-jeff just a heads up that I'm going to be adding a few commits on top of your branch to add ingestion code, etc. I'll try my best to not stomp on any of your changes, but letting you know so you aren't surprised if new commits appear and you need to sync your branch before comitting. |
|
@mo-jeff I've renamed each folder to match the collection id (removed the |
|
@mo-jeff updated the |

Description
Adding content for 8 collections. Things to note:
item_assetsis a static list based on the collection themesType of change
Please delete options that are not relevant.
How Has This Been Tested?
n/a
Checklist:
Please delete options that are not relevant.