Skip to content

Verify runc error from log file #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helsaawy merged 1 commit into from
Dec 18, 2025
+20 −6
Merged

Verify runc error from log file #2577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions internal/guest/runtime/runc/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,12 @@ func (c *container) Start() error {
if err != nil {
runcErr := getRuncLogError(logPath)
c.r.cleanupContainer(c.id) //nolint:errcheck
return errors.Wrapf(runcErr, "runc start failed with %v: %s", err, string(out))
if runcErr != nil {
return errors.Wrapf(runcErr, "runc start failed with %v: %s", err, string(out))
} else {
logrus.Warn("runc start failed without writing error to log file")
return errors.Wrapf(err, "runc start failed: %s", string(out))
}
}
return nil
}
Expand Down Expand Up @@ -145,8 +150,12 @@ func (c *container) Resume() error {
cmd := runcCommandLog(logPath, args...)
out, err := cmd.CombinedOutput()
if err != nil {
runcErr := getRuncLogError(logPath)
return errors.Wrapf(runcErr, "runc resume failed with %v: %s", err, string(out))
if runcErr := getRuncLogError(logPath); runcErr != nil {
return errors.Wrapf(runcErr, "runc resume failed with %v: %s", err, string(out))
} else {
logrus.Warn("runc resume failed without writing error to log file")
return errors.Wrapf(err, "runc resume failed: %s", string(out))
}
}
return nil
}
Expand Down Expand Up @@ -361,7 +370,7 @@ func (c *container) startProcess(
tempProcessDir string,
hasTerminal bool,
stdioSet *stdio.ConnectionSet, initialArgs ...string,
) (p *process, err error) {
) (_ *process, err error) {
args := initialArgs

if err := setSubreaper(1); err != nil {
Expand Down Expand Up @@ -413,8 +422,13 @@ func (c *container) startProcess(
}

if err := cmd.Run(); err != nil {
runcErr := getRuncLogError(logPath)
return nil, errors.Wrapf(runcErr, "failed to run runc create/exec call for container %s with %v", c.id, err)
if runcErr := getRuncLogError(logPath); runcErr != nil {
return nil, errors.Wrapf(runcErr, "runc create/exec call for container %s failed: %v", c.id, err)
} else {
logrus.Warn("runc create/exec call failed without writing error to log file")
return nil, errors.Wrapf(err, "runc create/exec call for container %s failed", c.id)
}

}

var ttyRelay *stdio.TtyRelay
Expand Down