Verify runc error from log file
#2577
Merged
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where `internal/guest/runtime/runc/container.go` code assumed that the logfile passed to runc would contain an error without checking. This can result in scenarios where `cmd.Run` (or `cmd.CombinedOutput`) returns a non-nil `err` but (due to a runc's failure to start or write to the log file, or the JSON is invalid) `runcErr` is nil and therefore the error returned by `errors.Wrapf` is also nil. Those scenarios can ultimately panic since it violates invariants where a nil error is assumed to mean a successful operation or a usable return value. Fix this by guarding on `runcErr == nil` and warn in those situations. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
approved these changes
Dec 17, 2025
apurv15
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where
internal/guest/runtime/runc/container.gocode assumed that the logfile passed to runc would contain an error without checking. This can result in scenarios wherecmd.Run(orcmd.CombinedOutput) returns a non-nilerrbut (due to a runc's failure to start or write to the log file, or the JSON is invalid)runcErris nil and therefore the error returned byerrors.Wrapfis also nil.Those scenarios can ultimately panic since it violates invariants where a nil error is assumed to mean a successful operation or a usable return value.
Fix this by guarding on
runcErr == niland warn in those situations.