Skip to content

Temporarily remove Dropdown test page + update XCode #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksiler merged 11 commits into from
Sep 10, 2025
+17 −9
Merged

Temporarily remove Dropdown test page + update XCode #3956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9346cca
Temporarily remove Dropdown test page
ksiler Sep 9, 2025
6717350
Change files
ksiler Sep 9, 2025
8d3d142
comment out dropdown imports
ksiler Sep 9, 2025
6740577
update xcode version
ksiler Sep 10, 2025
dfa7895
verify simulator availability
ksiler Sep 10, 2025
380807f
update destination for simulator
ksiler Sep 10, 2025
568cd4a
update iphone version and os
ksiler Sep 10, 2025
84e916d
test simulator ID
ksiler Sep 10, 2025
d6c1a04
revert destination change and downgrade to xcode 16
ksiler Sep 10, 2025
fc0b295
update to 16.4
ksiler Sep 10, 2025
6fb548c
Remove debug command
ksiler Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ado/variables/vars.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ variables:
- name: VmImageApple
value: macos-latest-internal
- name: xcode_friendly_name
value: 'Xcode 15.2'
value: 'Xcode 16.4'
- name: xcode_version
value: '/Applications/Xcode_15.2.app'
value: '/Applications/Xcode_16.4.app'
15 changes: 8 additions & 7 deletions apps/fluent-tester/src/testPages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { ContextualMenuTest } from './TestComponents/ContextualMenu';
import { CornerRadiusTokensTest } from './TestComponents/CornerRadius';
import { DividerTest } from './TestComponents/Divider';
import { DrawerTest } from './TestComponents/Drawer';
import { DropdownTest, HOMEPAGE_DROPDOWN_BUTTON } from './TestComponents/Dropdown';
// import { DropdownTest, HOMEPAGE_DROPDOWN_BUTTON } from './TestComponents/Dropdown';
// import { ExpanderTest, Constants.HOMEPAGE_EXPANDER_BUTTON } from './TestComponents/Expander';
import { FocusTrapTest } from './TestComponents/FocusTrapZone';
import { FocusZoneTest } from './TestComponents/FocusZone';
Expand Down Expand Up @@ -133,12 +133,13 @@ export const tests: TestDescription[] = [
testPageButton: Constants.HOMEPAGE_DIVIDER_BUTTON,
platforms: ['android', 'ios', 'macos', 'win32', 'windows'],
},
{
name: 'Dropdown',
component: DropdownTest,
testPageButton: HOMEPAGE_DROPDOWN_BUTTON,
platforms: ['macos', 'win32'],
},
// Temporarily disabling until Dropdown is fully implemented
// {
// name: 'Dropdown',
// component: DropdownTest,
// testPageButton: HOMEPAGE_DROPDOWN_BUTTON,
// platforms: ['macos', 'win32'],
// },
{
name: 'Drawer',
component: DrawerTest,
Expand Down
7 changes: 7 additions & 0 deletions change/@fluentui-react-native-tester-abd620b1-65b7-4117-9d29-c16beed97803.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Temporarily remove Dropdown test page",
"packageName": "@fluentui-react-native/tester",
"email": "krsiler@microsoft.com",
"dependentChangeType": "patch"
}