Skip to content

feat: Enhance email template, add RG owner tag, scalability input#592

Open
Vamshi-Microsoft wants to merge 2 commits into
devfrom
pls-workflowchanges
Open

feat: Enhance email template, add RG owner tag, scalability input#592
Vamshi-Microsoft wants to merge 2 commits into
devfrom
pls-workflowchanges

Conversation

@Vamshi-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request introduces support for an "Enable Scalability" option (primarily for WAF-enabled deployments) across multiple GitHub Actions workflows. It adds new input parameters, validation logic, and ensures the scalability flag is only applied when appropriate. Additionally, it improves resource group tagging by automatically setting or updating an "Owner" tag based on the GitHub actor.

Key changes include:

Scalability Option Support:

  • Added a new enableScalability (or ENABLE_SCALABILITY) input parameter to deployment workflows for Linux, Windows, and orchestrator jobs, allowing users to opt-in to scalability features when deploying with WAF. This includes input validation and conditional logic to ensure the flag is only effective for WAF deployments. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]

  • Updated deployment scripts to inject the scalability parameter into ARM template parameter files only when WAF is enabled, and to warn or ignore the flag otherwise. [1] [2]

Resource Group Tagging Improvements:

  • Enhanced resource group creation and update steps in deployment workflows to automatically set or merge an "Owner" tag based on the GitHub actor, ensuring better traceability of deployed resources. [1] [2] [3]

Input and Output Consistency:

  • Ensured that the new scalability flag is consistently passed through workflow inputs, validated, and mapped to job/environment variables across all affected workflows. [1] [2] [3] [4] [5] [6] [7] [8]

Workflow Input Description Updates:

  • Improved descriptions and naming for several workflow inputs to clarify their purpose and usage, including the scalability flag and other deployment options. [1] [2] [3]

These changes improve deployment flexibility, resource traceability, and make the workflows more robust and user-friendly.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant