feat: Enhance email template, add RG owner tag, scalability input#592
Open
Vamshi-Microsoft wants to merge 2 commits into
Open
feat: Enhance email template, add RG owner tag, scalability input#592Vamshi-Microsoft wants to merge 2 commits into
Vamshi-Microsoft wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces support for an "Enable Scalability" option (primarily for WAF-enabled deployments) across multiple GitHub Actions workflows. It adds new input parameters, validation logic, and ensures the scalability flag is only applied when appropriate. Additionally, it improves resource group tagging by automatically setting or updating an "Owner" tag based on the GitHub actor.
Key changes include:
Scalability Option Support:
Added a new
enableScalability(orENABLE_SCALABILITY) input parameter to deployment workflows for Linux, Windows, and orchestrator jobs, allowing users to opt-in to scalability features when deploying with WAF. This includes input validation and conditional logic to ensure the flag is only effective for WAF deployments. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]Updated deployment scripts to inject the scalability parameter into ARM template parameter files only when WAF is enabled, and to warn or ignore the flag otherwise. [1] [2]
Resource Group Tagging Improvements:
Input and Output Consistency:
Workflow Input Description Updates:
These changes improve deployment flexibility, resource traceability, and make the workflows more robust and user-friendly.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation